diff options
| author | Andrzej Warzyński <andrzej.warzynski@arm.com> | 2025-07-02 20:07:35 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-02 20:07:35 +0100 |
| commit | 6ecb6a8a8cd5c604ae109bc84dfd317117e1ed43 (patch) | |
| tree | 3592bef4bdf9136c0f27eea480fab7389f174a0e /mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp | |
| parent | ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75 (diff) | |
[mlir][vector][nfc] Rename `populateVectorTransferCollapseInnerMostContiguousDimsPatterns` (#145228)
Renames `populateVectorTransferCollapseInnerMostContiguousDimsPatterns`
as `populateDropInnerMostUnitDimsXferOpPatterns` + updates the
corresponding comments.
This addresses a TODO and makes the difference between these two
`populate*` methods clearer:
* `populateDropUnitDimWithShapeCastPatterns`,
* `populateDropInnerMostUnitDimsXferOpPatterns`.
Diffstat (limited to 'mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp')
| -rw-r--r-- | mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp index 36fc55f3f311..bcaea1c79471 100644 --- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp +++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp @@ -2266,11 +2266,6 @@ void mlir::vector::populateVectorMaskMaterializationPatterns( void mlir::vector::populateDropUnitDimWithShapeCastPatterns( RewritePatternSet &patterns, PatternBenefit benefit) { - // TODO: Consider either: - // * including DropInnerMostUnitDimsTransferRead and - // DropInnerMostUnitDimsTransferWrite, or - // * better naming to distinguish this and - // populateVectorTransferCollapseInnerMostContiguousDimsPatterns. patterns.add<DropUnitDimFromElementwiseOps, DropUnitDimsFromScfForOp, DropUnitDimsFromTransposeOp>(patterns.getContext(), benefit); } @@ -2305,9 +2300,8 @@ void mlir::vector::populateVectorReductionToContractPatterns( patterns.getContext(), benefit); } -void mlir::vector:: - populateVectorTransferCollapseInnerMostContiguousDimsPatterns( - RewritePatternSet &patterns, PatternBenefit benefit) { +void mlir::vector::populateDropInnerMostUnitDimsXferOpPatterns( + RewritePatternSet &patterns, PatternBenefit benefit) { patterns.add<DropInnerMostUnitDimsTransferRead, DropInnerMostUnitDimsTransferWrite>(patterns.getContext(), benefit); |