From 6ecb6a8a8cd5c604ae109bc84dfd317117e1ed43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrzej=20Warzy=C5=84ski?= Date: Wed, 2 Jul 2025 20:07:35 +0100 Subject: [mlir][vector][nfc] Rename `populateVectorTransferCollapseInnerMostContiguousDimsPatterns` (#145228) Renames `populateVectorTransferCollapseInnerMostContiguousDimsPatterns` as `populateDropInnerMostUnitDimsXferOpPatterns` + updates the corresponding comments. This addresses a TODO and makes the difference between these two `populate*` methods clearer: * `populateDropUnitDimWithShapeCastPatterns`, * `populateDropInnerMostUnitDimsXferOpPatterns`. --- mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp') diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp index 36fc55f3f311..bcaea1c79471 100644 --- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp +++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp @@ -2266,11 +2266,6 @@ void mlir::vector::populateVectorMaskMaterializationPatterns( void mlir::vector::populateDropUnitDimWithShapeCastPatterns( RewritePatternSet &patterns, PatternBenefit benefit) { - // TODO: Consider either: - // * including DropInnerMostUnitDimsTransferRead and - // DropInnerMostUnitDimsTransferWrite, or - // * better naming to distinguish this and - // populateVectorTransferCollapseInnerMostContiguousDimsPatterns. patterns.add(patterns.getContext(), benefit); } @@ -2305,9 +2300,8 @@ void mlir::vector::populateVectorReductionToContractPatterns( patterns.getContext(), benefit); } -void mlir::vector:: - populateVectorTransferCollapseInnerMostContiguousDimsPatterns( - RewritePatternSet &patterns, PatternBenefit benefit) { +void mlir::vector::populateDropInnerMostUnitDimsXferOpPatterns( + RewritePatternSet &patterns, PatternBenefit benefit) { patterns.add(patterns.getContext(), benefit); -- cgit v1.2.3