diff options
| author | Shubham Sandeep Rastogi <srastogi22@apple.com> | 2022-01-21 13:43:51 -0800 |
|---|---|---|
| committer | Shubham Sandeep Rastogi <srastogi22@apple.com> | 2022-01-21 13:45:51 -0800 |
| commit | 6103b2d45bfb43bb403d289d80c137d5155b0778 (patch) | |
| tree | bbe4cc5d9121c387f7afb71c9896926584c6cbcd /llvm/lib | |
| parent | 9f4cc5a6bb56b42bb90ea31f10ecf8fed8f07653 (diff) | |
Revert "Emit swift5 reflection section data in dsym bundle generated by dsymutil in the Dwarf section."
This reverts commit d84d1135d80c1dead6564347943ba56eed5aac3b. to investigate buildbot failures
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/DWARFLinker/DWARFStreamer.cpp | 20 | ||||
| -rw-r--r-- | llvm/lib/MC/MCContext.cpp | 8 | ||||
| -rw-r--r-- | llvm/lib/MC/MCObjectFileInfo.cpp | 11 | ||||
| -rw-r--r-- | llvm/lib/Object/MachOObjectFile.cpp | 12 |
4 files changed, 7 insertions, 44 deletions
diff --git a/llvm/lib/DWARFLinker/DWARFStreamer.cpp b/llvm/lib/DWARFLinker/DWARFStreamer.cpp index 7f9b9a9bc793..1ab6ead3b5f6 100644 --- a/llvm/lib/DWARFLinker/DWARFStreamer.cpp +++ b/llvm/lib/DWARFLinker/DWARFStreamer.cpp @@ -27,8 +27,7 @@ namespace llvm { -bool DwarfStreamer::init(Triple TheTriple, - StringRef Swift5ReflectionSegmentName) { +bool DwarfStreamer::init(Triple TheTriple) { std::string ErrorStr; std::string TripleName; StringRef Context = "dwarf streamer init"; @@ -55,9 +54,8 @@ bool DwarfStreamer::init(Triple TheTriple, if (!MSTI) return error("no subtarget info for target " + TripleName, Context), false; - MC.reset(new MCContext(TheTriple, MAI.get(), MRI.get(), MSTI.get(), nullptr, - nullptr, true, Swift5ReflectionSegmentName)); - MOFI.reset(TheTarget->createMCObjectFileInfo(*MC, /*PIC=*/false, false)); + MC.reset(new MCContext(TheTriple, MAI.get(), MRI.get(), MSTI.get())); + MOFI.reset(TheTarget->createMCObjectFileInfo(*MC, /*PIC=*/false)); MC->setObjectFileInfo(MOFI.get()); MAB = TheTarget->createMCAsmBackend(*MSTI, *MRI, MCOptions); @@ -304,18 +302,6 @@ void DwarfStreamer::emitSwiftAST(StringRef Buffer) { MS->emitBytes(Buffer); } -void DwarfStreamer::emitSwiftReflectionSection( - llvm::swift::Swift5ReflectionSectionKind ReflSectionKind, StringRef Buffer, - uint32_t Alignment, uint32_t Size) { - MCSection *ReflectionSection = - MOFI->getSwift5ReflectionSection(ReflSectionKind); - if (ReflectionSection == nullptr) - return; - ReflectionSection->setAlignment(Align(Alignment)); - MS->SwitchSection(ReflectionSection); - MS->emitBytes(Buffer); -} - /// Emit the debug_range section contents for \p FuncRange by /// translating the original \p Entries. The debug_range section /// format is totally trivial, consisting just of pairs of address diff --git a/llvm/lib/MC/MCContext.cpp b/llvm/lib/MC/MCContext.cpp index eafcee1e0607..7f639e9c408f 100644 --- a/llvm/lib/MC/MCContext.cpp +++ b/llvm/lib/MC/MCContext.cpp @@ -67,10 +67,10 @@ static void defaultDiagHandler(const SMDiagnostic &SMD, bool, const SourceMgr &, MCContext::MCContext(const Triple &TheTriple, const MCAsmInfo *mai, const MCRegisterInfo *mri, const MCSubtargetInfo *msti, const SourceMgr *mgr, MCTargetOptions const *TargetOpts, - bool DoAutoReset, StringRef Swift5ReflSegmentName) - : Swift5ReflectionSegmentName(Swift5ReflSegmentName), TT(TheTriple), - SrcMgr(mgr), InlineSrcMgr(nullptr), DiagHandler(defaultDiagHandler), - MAI(mai), MRI(mri), MSTI(msti), Symbols(Allocator), UsedNames(Allocator), + bool DoAutoReset) + : TT(TheTriple), SrcMgr(mgr), InlineSrcMgr(nullptr), + DiagHandler(defaultDiagHandler), MAI(mai), MRI(mri), MSTI(msti), + Symbols(Allocator), UsedNames(Allocator), InlineAsmUsedLabelNames(Allocator), CurrentDwarfLoc(0, 0, 0, DWARF2_FLAG_IS_STMT, 0, 0), AutoReset(DoAutoReset), TargetOptions(TargetOpts) { diff --git a/llvm/lib/MC/MCObjectFileInfo.cpp b/llvm/lib/MC/MCObjectFileInfo.cpp index 77b0b0ee687c..d7f85f793c55 100644 --- a/llvm/lib/MC/MCObjectFileInfo.cpp +++ b/llvm/lib/MC/MCObjectFileInfo.cpp @@ -299,17 +299,6 @@ void MCObjectFileInfo::initMachOMCObjectFileInfo(const Triple &T) { RemarksSection = Ctx->getMachOSection( "__LLVM", "__remarks", MachO::S_ATTR_DEBUG, SectionKind::getMetadata()); - // The architecture of dsymutil makes it very difficult to copy the Swift - // reflection metadata sections into the __TEXT segment, so dsymutil creates - // these sections in the __DWARF segment instead. - if (!Ctx->getSwift5ReflectionSegmentName().empty()) { -#define HANDLE_SWIFT_SECTION(KIND, MACHO, ELF, COFF) \ - Swift5ReflectionSections[llvm::swift::Swift5ReflectionSectionKind::KIND] = \ - Ctx->getMachOSection(Ctx->getSwift5ReflectionSegmentName().data(), \ - MACHO, 0, SectionKind::getMetadata()); -#include "llvm/BinaryFormat/Swift.def" - } - TLSExtraDataSection = TLSTLVSection; } diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp index 83bc74ff31c4..42e257516f4e 100644 --- a/llvm/lib/Object/MachOObjectFile.cpp +++ b/llvm/lib/Object/MachOObjectFile.cpp @@ -20,7 +20,6 @@ #include "llvm/ADT/Triple.h" #include "llvm/ADT/Twine.h" #include "llvm/BinaryFormat/MachO.h" -#include "llvm/BinaryFormat/Swift.h" #include "llvm/Object/Error.h" #include "llvm/Object/MachO.h" #include "llvm/Object/ObjectFile.h" @@ -4766,14 +4765,3 @@ MachOObjectFile::findDsymObjectMembers(StringRef Path) { Path.str().c_str()); return ObjectPaths; } - -llvm::swift::Swift5ReflectionSectionKind -MachOObjectFile::mapReflectionSectionNameToEnumValue( - StringRef SectionName) const { -#define HANDLE_SWIFT_SECTION(KIND, MACHO, ELF, COFF) \ - .Case(MACHO, llvm::swift::Swift5ReflectionSectionKind::KIND) - return StringSwitch<llvm::swift::Swift5ReflectionSectionKind>(SectionName) -#include "llvm/BinaryFormat/Swift.def" - .Default(llvm::swift::Swift5ReflectionSectionKind::Unknown); -#undef HANDLE_SWIFT_SECTION -} |
