summaryrefslogtreecommitdiff
path: root/lldb/test/Shell/Commands/command-backtrace-parser-1.test
AgeCommit message (Collapse)Author
2021-06-14Reland "[lldb] Set return status to failed when adding a command error"David Spickett
This reverts commit ac031c8db2ce454a9b08f23192ce698e8bde4447. SB API usage has been corrected.
2021-06-14Revert "[lldb] Set return status to failed when adding a command error" (and ↵David Spickett
fixups) This reverts commit f583029da3d6dbabe82f48b160227eb0120abd33, 0f94d68a2e15d50796439f20bcb508b95931d2ae and a2363c0cf9b6a9a81c76ac652da667f73845d38b. Due to test failures from incorrect SB API usage.
2021-06-14Reland "[lldb] Set return status to failed when adding a command error"David Spickett
This reverts commit db93e4e70aa453e5ba04ba0d9e01f581882b6c81. This modifies TestRegsters.py to account for Darwin showing AVX registers as part of "Floating Point Registers" instead of in a separate "Advanced Vector Extensions" category.
2021-06-09Revert "[lldb] Set return status to failed when adding a command error"David Spickett
This reverts commit e05b03cf4f45ac5ee63c59a3464e7d484884645c. While I investigate a register test failure: http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/detail/lldb-cmake/32693/pipeline/
2021-06-08[lldb] Set return status to failed when adding a command errorDavid Spickett
There is a common pattern: result.AppendError(...); result.SetStatus(eReturnStatusFailed); I found that some commands don't actually "fail" but only print "error: ..." because the second line got missed. This can cause you to miss a failed command when you're using the Python interface during testing. (and produce some confusing script results) I did not find any place where you would want to add an error without setting the return status, so just set eReturnStatusFailed whenever you add an error to a command result. This change does not remove any of the now redundant SetStatus. This should allow us to see if there are any tests that have commands unexpectedly fail with this change. (the test suite passes for me but I don't have access to all the systems we cover so there could be some corner cases) Some tests that failed on x86 and AArch64 have been modified to work with the new behaviour. Differential Revision: https://reviews.llvm.org/D103701