diff options
| author | Mircea Trofin <mtrofin@google.com> | 2024-05-15 10:34:47 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-15 10:34:47 -0700 |
| commit | 217668f641e82f901645f428ae0d07a3c01e9a8a (patch) | |
| tree | d2c428d07a420c27b3b7aea38d6b9be55ac9ea9e /offload/src/OpenMP/API.cpp | |
| parent | d92c67784f21063d6334a009dbf4f9e0f8217b41 (diff) | |
[nfc] Allow forwarding `Error` returns from `Expected` callers (#92208)
On a few compilers (clang 11/12 for example [1]), the following does not
result in a copy elision, and since `Error`'s copy dtor is elided,
results in a compile error:
```
Expect<Something> foobar() {
...
if (Error E = aCallReturningError())
return E;
...
}
```
Moving `E` would, conversely, result in the pessimizing-move warning on
more recent clangs ("moving a local object in a return statement
prevents copy elision")
We just need to make the `Expected` ctor taking an `Error` take it as a
r-value reference.
[1] https://lab.llvm.org/buildbot/#/builders/54/builds/10505
Diffstat (limited to 'offload/src/OpenMP/API.cpp')
0 files changed, 0 insertions, 0 deletions
