summaryrefslogtreecommitdiff
path: root/mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
diff options
context:
space:
mode:
authorHongren Zheng <i@zenithal.me>2025-05-12 17:21:44 +0800
committerGitHub <noreply@github.com>2025-05-12 17:21:44 +0800
commitd102e90de5d1fd0ea1e0395d64d4be7af88669c7 (patch)
tree525b1a605affa13e86fdd9fe62c521b1726b2c7f /mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
parentd9ac4d62f875948ffa8928f167d4765b922dc33e (diff)
[mlir][MLProgram][NFC] Migrate to OpAsmAttrInterface for ASM alias generation (#130481)
After the introduction of `OpAsmAttrInterface`, it is favorable to migrate code using `OpAsmDialectInterface` for ASM alias generation, which lives in `Dialect.cpp`, to use `OpAsmAttrInterface`, which lives in `Attrs.td`. In this way, attribute behavior is placed near its tablegen definition and people won't need to go through other files to know what other (unexpected) hooks comes into play. See #124721 for the interface itself and #128191 and #130479 for prior migrations. Note that `MLProgramOpAsmInterface` has no content now. However, if we delete it, a failure related to dialect resource handling will occur ``` within split at llvm-project/mlir/test/IR/invalid-file-metadata.mlir:60 offset :7:7: error: unexpected error: unexpected 'resource' section for dialect 'ml_program' ``` To support resource such interface must be registered.
Diffstat (limited to 'mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp')
-rw-r--r--mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp8
1 files changed, 0 insertions, 8 deletions
diff --git a/mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp b/mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
index bda1032ed988..0b1561213165 100644
--- a/mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
+++ b/mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
@@ -39,14 +39,6 @@ struct MLProgramInlinerInterface : public DialectInlinerInterface {
struct MLProgramOpAsmDialectInterface : public OpAsmDialectInterface {
using OpAsmDialectInterface::OpAsmDialectInterface;
-
- AliasResult getAlias(Attribute attr, raw_ostream &os) const override {
- if (llvm::isa<ExternAttr>(attr)) {
- os << "extern";
- return AliasResult::OverridableAlias;
- }
- return AliasResult::NoAlias;
- }
};
} // namespace