diff options
| author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2023-03-01 19:03:56 +0000 |
|---|---|---|
| committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2023-03-01 19:04:03 +0000 |
| commit | 73cdccad55550fca4bb8b1c2d0cbe9e9218aaa6b (patch) | |
| tree | 67111cf0a7f2ee94c6bb02bb081d089d1493f615 /mlir/lib/Bytecode/Reader/BytecodeReader.cpp | |
| parent | a4d39d4b69b265ee41b08cd04f5292e3ddb31aeb (diff) | |
[DAG] expandIntMINMAX - attempt to match existing SETCC node
As noticed on D144789, when we have pairs of min/max nodes we often end up with multiple comparisons which we could reuse with commuted select ops, so check to see if a suitable SETCC already exists. This also allowed us to remove a similar X86 peephole.
There are other getSETCC cases where we could safely reuse other CondCodes as well - I've been trying to think of how we could reuse this logic in SelectionDAG but haven't found anything that always works well.
An alternative would be to have a TLI callback that returns a preferred CondCode from a list of options, I've noticed this helped fpclamptosat tests on some other targets (MVE + WebAssembly), but other tests suffered.
Differential Revision: https://reviews.llvm.org/D145065
Diffstat (limited to 'mlir/lib/Bytecode/Reader/BytecodeReader.cpp')
0 files changed, 0 insertions, 0 deletions