diff options
| author | Matthias Braun <matze@braunis.de> | 2017-01-28 02:02:38 +0000 |
|---|---|---|
| committer | Matthias Braun <matze@braunis.de> | 2017-01-28 02:02:38 +0000 |
| commit | 8c209aa8779de57771b64896f805e14cc0016dcd (patch) | |
| tree | b3f7bc33dbb7be8ffe9a4f974253d6547b94ebdb /llvm/utils/TableGen/CallingConvEmitter.cpp | |
| parent | cfa5dc4a1dc2b7495aba96caba6fd2600c1ceb8a (diff) | |
Cleanup dump() functions.
We had various variants of defining dump() functions in LLVM. Normalize
them (this should just consistently implement the things discussed in
http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html
For reference:
- Public headers should just declare the dump() method but not use
LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
- The definition of a dump method should look like this:
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void MyClass::dump() {
// print stuff to dbgs()...
}
#endif
llvm-svn: 293359
Diffstat (limited to 'llvm/utils/TableGen/CallingConvEmitter.cpp')
| -rw-r--r-- | llvm/utils/TableGen/CallingConvEmitter.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/utils/TableGen/CallingConvEmitter.cpp b/llvm/utils/TableGen/CallingConvEmitter.cpp index a47662b28558..013e96065752 100644 --- a/llvm/utils/TableGen/CallingConvEmitter.cpp +++ b/llvm/utils/TableGen/CallingConvEmitter.cpp @@ -96,7 +96,7 @@ void CallingConvEmitter::EmitAction(Record *Action, } else if (Action->isSubClassOf("CCIf")) { O << Action->getValueAsString("Predicate"); } else { - Action->dump(); + errs() << *Action; PrintFatalError("Unknown CCPredicateAction!"); } @@ -268,7 +268,7 @@ void CallingConvEmitter::EmitAction(Record *Action, << "LocVT, LocInfo, ArgFlags, State))\n"; O << IndentStr << IndentStr << "return false;\n"; } else { - Action->dump(); + errs() << *Action; PrintFatalError("Unknown CCAction!"); } } |
