diff options
| author | Florian Hahn <flo@fhahn.com> | 2022-09-19 18:14:34 +0100 |
|---|---|---|
| committer | Tobias Hieta <tobias@hieta.se> | 2022-09-20 08:05:50 +0200 |
| commit | b73d2c8c720a8c8e6e73b11be4e27afa6cb75bdf (patch) | |
| tree | 5dae2a4815c55c2da1c80b36d5276bb1844c01ae /llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp | |
| parent | 38b5fa73d58576df84852c6bbf6d8219de69428b (diff) | |
[LV] Keep track of cost-based ScalarAfterVec in VPWidenPointerInd.llvmorg-15.0.1
Epilogue vectorization uses isScalarAfterVectorization to check if
widened versions for inductions need to be generated and bails out in
those cases.
At the moment, there are scenarios where isScalarAfterVectorization
returns true but VPWidenPointerInduction::onlyScalarsGenerated would
return false, causing widening.
This can lead to widened phis with incorrect start values being created
in the epilogue vector body.
This patch addresses the issue by storing the cost-model decision in
VPWidenPointerInductionRecipe and restoring the behavior before 151c144.
This effectively reverts 151c144, but the long-term fix is to properly
support widened inductions during epilogue vectorization
Fixes #57712.
Diffstat (limited to 'llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp')
| -rw-r--r-- | llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp b/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp index cb7507264667..f214563af6cc 100644 --- a/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp +++ b/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp @@ -982,11 +982,8 @@ void VPCanonicalIVPHIRecipe::print(raw_ostream &O, const Twine &Indent, } #endif -bool VPWidenPointerInductionRecipe::onlyScalarsGenerated(ElementCount VF) { - bool IsUniform = vputils::onlyFirstLaneUsed(this); - return all_of(users(), - [&](const VPUser *U) { return U->usesScalars(this); }) && - (IsUniform || !VF.isScalable()); +bool VPWidenPointerInductionRecipe::onlyScalarsGenerated() { + return IsScalarAfterVectorization; } #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) |
