diff options
| author | Kazu Hirata <kazu@google.com> | 2024-08-21 16:53:18 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-21 16:53:18 -0700 |
| commit | fdbc4089e7a6eafa4002a7981bcde94fc378bc18 (patch) | |
| tree | 666b948728d161226b92845e8dda548872860590 /llvm/lib/Transforms/IPO/FunctionImport.cpp | |
| parent | ec8fe7ad81af6c211fb26c34824092e5bca08f5e (diff) | |
[LTO] Compare std::optional<ImportKind> directly with ImportKind (NFC) (#105561)
Note that:
Opt == Val if and only (Opt && *Opt == Val)
where:
std::optional<T> Opt;
T Val;
Diffstat (limited to 'llvm/lib/Transforms/IPO/FunctionImport.cpp')
| -rw-r--r-- | llvm/lib/Transforms/IPO/FunctionImport.cpp | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp index 6ae89a49b6b9..92371720e0ec 100644 --- a/llvm/lib/Transforms/IPO/FunctionImport.cpp +++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp @@ -1814,10 +1814,7 @@ Expected<bool> FunctionImporter::importFunctions( continue; auto GUID = F.getGUID(); auto MaybeImportType = getImportType(ImportGUIDs, GUID); - - bool ImportDefinition = - (MaybeImportType && - (*MaybeImportType == GlobalValueSummary::Definition)); + bool ImportDefinition = MaybeImportType == GlobalValueSummary::Definition; LLVM_DEBUG(dbgs() << (MaybeImportType ? "Is" : "Not") << " importing function" @@ -1853,10 +1850,7 @@ Expected<bool> FunctionImporter::importFunctions( continue; auto GUID = GV.getGUID(); auto MaybeImportType = getImportType(ImportGUIDs, GUID); - - bool ImportDefinition = - (MaybeImportType && - (*MaybeImportType == GlobalValueSummary::Definition)); + bool ImportDefinition = MaybeImportType == GlobalValueSummary::Definition; LLVM_DEBUG(dbgs() << (MaybeImportType ? "Is" : "Not") << " importing global" @@ -1876,10 +1870,7 @@ Expected<bool> FunctionImporter::importFunctions( continue; auto GUID = GA.getGUID(); auto MaybeImportType = getImportType(ImportGUIDs, GUID); - - bool ImportDefinition = - (MaybeImportType && - (*MaybeImportType == GlobalValueSummary::Definition)); + bool ImportDefinition = MaybeImportType == GlobalValueSummary::Definition; LLVM_DEBUG(dbgs() << (MaybeImportType ? "Is" : "Not") << " importing alias" |