diff options
| author | Chuanqi Xu <yedeng.yd@linux.alibaba.com> | 2023-01-17 17:26:48 +0800 |
|---|---|---|
| committer | Chuanqi Xu <yedeng.yd@linux.alibaba.com> | 2023-01-17 17:48:09 +0800 |
| commit | b3eb004ca78f522c91c0d83bafeab2ee753417c8 (patch) | |
| tree | c00396b36da23c6fb5f5f8d0e9bf3c14b8ab3686 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
| parent | 546b710c10fa6cd7eee4bafb80c9cd191f1bd75d (diff) | |
[C++20] [Modules] Only diagnose the non-inline external variable
definitions in header units
Address part of https://github.com/llvm/llvm-project/issues/60079.
Since the the declaration of a non-inline static data member in its
class definition is not a definition. The following form:
```
class A {
public:
static const int value = 43;
};
```
should be fine to appear in a header unit. From the perspective of
implementation, it looks like we simply forgot to check if the variable
is a definition...
Reviewed By: iains
Differential Revision: https://reviews.llvm.org/D141905
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions
