diff options
| author | Heejin Ahn <aheejin@gmail.com> | 2024-02-06 17:07:33 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-06 17:07:33 -0800 |
| commit | 897297e8b09ed6076f5dc6883b459b209bb9e29f (patch) | |
| tree | a4ecab2c71dacb5c5508fdba0c2d714f4513d71e /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
| parent | 44767278650227b30cf969170dc139197ce4338d (diff) | |
[WebAssembly] Fix CPU tests in wasm-features.c (#80900)
The CPU tests in this file are not working as intended. Specifying
`-mcpu=[mvp|generic|bleeding-edge]` in `clang` command line does NOT add
arguments like `-target-feature`, `+feature-name`, ... to `clang-14`
command line. Specifying `-mcpu=[mvp|generic|bleeding-edge]` in `clang`
command line will just add `-target-cpu` `[mvp|generic|bleeding-edge]`
to `clang-14` command line, and individual features are added here
within `clang-14` invocation:
https://github.com/llvm/llvm-project/blob/5b780c8c6c558ec283a9eec485a4f172df0f9fe1/clang/lib/Basic/Targets/WebAssembly.cpp#L150-L163
The reason these CPU tests are passing is because they only have `-NOT`
checks, and we don't emit `-target-feature` arguments for them anyway,
the test passes, but they don't check what they are supposed to check.
This make CPU tests only check `-target-cpu` lines instead of individual
features, which will not be emitted.
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions