diff options
| author | John Ericson <John.Ericson@Obsidian.Systems> | 2021-12-12 17:07:13 +0000 |
|---|---|---|
| committer | John Ericson <John.Ericson@Obsidian.Systems> | 2021-12-13 21:27:39 +0000 |
| commit | 5f7afa96071c7fffb44c253a63c1c552f98a9c79 (patch) | |
| tree | 29ec8aefd620c23619efed5636b001dcea16737f /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
| parent | a6a07a514b8a084feaa7f4f15d569698b9840d83 (diff) | |
Simplify AddSphinxTarget.cmake by just including `GNUInstallDirs`
See the discussion in D30906 for how it must be robust to downstream
projects that might not use `GNUInstallDirs`.
I think an easier approach is just to include `GNUInstallDirs` so that
we can always rely on it. Looking at its definition in
https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/GNUInstallDirs.cmake
it appears safe to include multiple times.
I am trying this out because we will face the same problem many times
over if we use `GNUInstallDirs` more widely, as proposed in D99484 and
its parent revisions, since we do not know what downstream projects do
and rather not break them.
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D115601
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions