summaryrefslogtreecommitdiff
path: root/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
diff options
context:
space:
mode:
authorNathan James <n.james93@hotmail.co.uk>2020-04-05 15:33:34 +0100
committerNathan James <n.james93@hotmail.co.uk>2020-04-06 20:00:30 +0100
commit427c1dc4f4248ec71e32a8f3832a4e6258446672 (patch)
tree8fda2d75f8feda20bca8fd54c504c1814d82b8c9 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp
parent53b7abdd238c89346e5516928af675e5ca973124 (diff)
[ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments
Summary: This adds support for giving hints when using dynamic matchers with enum args. Take this query, I couldn't figure out why the matcher wasn't working: (Turns out it needed to be "IntegralToBoolean", but thats another bug itself) ``` clang-query> match implicitCastExpr(hasCastKind("CK_IntegralToBoolean")) 1:1: Error parsing argument 1 for matcher implicitCastExpr. 1:18: Error building matcher hasCastKind. 1:30: Incorrect type for arg 1. (Expected = string) != (Actual = String) ``` With this patch the new behaviour looks like this: ``` clang-query> match implicitCastExpr(hasCastKind("CK_IntegralToBoolean")) 1:1: Error parsing argument 1 for matcher implicitCastExpr. 1:18: Error building matcher hasCastKind. 1:30: Unknown value 'CK_IntegralToBoolean' for arg 1; did you mean 'IntegralToBoolean' ``` There are no test cases for this yet as there simply isn't any infrastructure for testing errors reported when parsing args that I can see. Reviewers: klimek, jdoerfert, aaron.ballman Reviewed By: aaron.ballman Subscribers: aaron.ballman, dexonsmith, mgorny, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D77499
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions