summaryrefslogtreecommitdiff
path: root/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
diff options
context:
space:
mode:
authorTies Stuij <ties.stuij@arm.com>2020-07-08 13:12:30 +0100
committerTies Stuij <ties.stuij@arm.com>2020-07-08 15:29:57 +0100
commit26a22478cdfe6fe4d169320910c38958d5dafc38 (patch)
treedeace0cdb68f0da1dc0f805ee7afa087460d1691 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp
parentea8bba7e8d0db3541a386ad649c4bf21d53e8380 (diff)
[CodeGen] Don't combine extract + concat vectors with non-legal types
Summary: The following combine currently breaks in the DAGCombiner: ``` extract_vector_elt (concat_vectors v4i16:a, v4i16:b), x -> extract_vector_elt a, x ``` This happens because after we have combined these nodes we have inserted nodes that use individual instances of the vector element type. In the above example i16. However this isn't a legal type on all backends, and when the combining pass calls the legalizer it breaks as it expects types to already be legal. The type legalizer has already been run, and running it again would make a mess of the nodes. In the example code at least, the generated code is still efficient after the change. Reviewers: miyuki, arsenm, dmgreen, lebedev.ri Reviewed By: miyuki, lebedev.ri Subscribers: lebedev.ri, wdng, hiraditya, steven.zhang, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D83231
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions