diff options
| author | Amara Emerson <amara@apple.com> | 2023-10-28 22:32:00 -0700 |
|---|---|---|
| committer | Amara Emerson <amara@apple.com> | 2023-10-28 23:21:11 -0700 |
| commit | 1a2e77cf9e11dbf56b5720c607313a566eebb16e (patch) | |
| tree | 42d1a582039d8f1b9e0dc88816f50f8904f4b81a /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
| parent | ebc2c4bde3ec0d37d1bcb224e7ffcc18ac4e2620 (diff) | |
Revert "Revert "Inlining: Run the legacy AlwaysInliner before the regular inliner.""
This reverts commit 86bfeb906e3a95ae428f3e97d78d3d22a7c839f3.
This is a long time coming re-application that was originally reverted due to
regressions, unrelated to the actual inlining change. These regressions have since
been fixed due to another long-in-the-making change of a66051c6 landing.
Original commit message for reference:
---
We have several situations where it's beneficial for code size to ensure that every
call to always-inline functions are inlined before normal inlining decisions are
made. While the normal inliner runs in a "MandatoryOnly" mode to try to do this,
it only does it on a per-SCC basis, rather than the whole module. Ensuring that
all mandatory inlinings are done before any heuristic based decisions are made
just makes sense.
Despite being referred to the "legacy" AlwaysInliner pass, it's already necessary
for -O0 because the CGSCC inliner is too expensive in compile time to run at -O0.
This also fixes an exponential compile time blow up in
https://github.com/llvm/llvm-project/issues/59126
Differential Revision: https://reviews.llvm.org/D143624
---
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions
