diff options
| author | Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> | 2020-07-23 10:45:25 +0100 |
|---|---|---|
| committer | Alex Richardson <Alexander.Richardson@cl.cam.ac.uk> | 2020-07-23 11:19:18 +0100 |
| commit | 9020d28688492c437abb648b6ab69baeba523219 (patch) | |
| tree | 4e8988267549fde8e7b218eb50745e3a9790a114 /llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp | |
| parent | 1162ffe8f4b78e22fef69218054a3a58312c7d30 (diff) | |
[libcxx][lit] Fix incorrect lambda capture in hasLocale checks
The lambda being used to check whether locales are supported was always
passing the value of alts from the last loop iteration due to the way that
python lambda captures work. Fix this by using a default argument capture.
To help debug future similar issues I also added a prefix to the config
test binary indicating which locale is being tested.
I originally found this issue when implementing a new executor that simply
collects test binaries in a given directory and was surprised to see many
additional executables other than the expected test binaries. I therefore
added the locale prefix to the test binaries and noticed that they were all
checking for cs_CZ.ISO8859-2.
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D84040
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp')
0 files changed, 0 insertions, 0 deletions