Redesign of the interaction between Python and frozen objects:

 - introduced two new classes ValueObjectConstResultChild and ValueObjectConstResultImpl: the first one is a ValueObjectChild obtained from
   a ValueObjectConstResult, the second is a common implementation backend for VOCR and VOCRCh of method calls meant to read through pointers stored
   in frozen objects ; now such reads transparently move from host to target as required
 - as a consequence of the above, removed code that made target-memory copies of expression results in several places throughout LLDB, and also
   removed code that enabled to recognize an expression result VO as such
 - introduced a new GetPointeeData() method in ValueObject that lets you read a given amount of objects of type T from a VO
   representing a T* or T[], and doing dereferences transparently
   in private layer it returns a DataExtractor ; in public layer it returns an instance of a newly created lldb::SBData
 - as GetPointeeData() does the right thing for both frozen and non-frozen ValueObject's, reimplemented ReadPointedString() to use it
   en lieu of doing the raw read itself
 - introduced a new GetData() method in ValueObject that lets you get a copy of the data that backs the ValueObject (for pointers,
   this returns the address without any previous dereferencing steps ; for arrays it actually reads the whole chunk of memory)
   in public layer this returns an SBData, just like GetPointeeData()
 - introduced a new CreateValueFromData() method in SBValue that lets you create a new SBValue from a chunk of data wrapped in an SBData
   the limitation to remember for this kind of SBValue is that they have no address: extracting the address-of for these objects (with any
   of GetAddress(), GetLoadAddress() and AddressOf()) will return invalid values
 - added several tests to check that "p"-ing objects (STL classes, char* and char[]) will do the right thing
Solved a bug where global pointers to global variables were not dereferenced correctly for display
New target setting "max-string-summary-length" gives the maximum number of characters to show in a string when summarizing it, instead of the hardcoded 128
Solved a bug where the summary for char[] and char* would not be shown if the ValueObject's were dumped via the "p" command
Removed m_pointers_point_to_load_addrs from ValueObject. Introduced a new m_address_type_of_children, which each ValueObject can set to tell the address type
 of any pointers and/or references it creates. In the current codebase, this is load address most of the time (the only notable exception being file
 addresses that generate file address children UNLESS we have a live process)
Updated help text for summary-string
Fixed an issue in STL formatters where std::stlcontainer::iterator would match the container's synthetic children providers
Edited the syntax and help for some commands to have proper argument types

llvm-svn: 139160

1 files changed, 71 insertions, 2 deletions

diff --git a/lldb/test/functionalities/target_command/TestTargetCommand.py b/lldb/test/functionalities/target_command/TestTargetCommand.py
index 600b19eca265..3f0bef3dc35c 100644
--- a/lldb/test/functionalities/target_command/TestTargetCommand.py
+++ b/lldb/test/functionalities/target_command/TestTargetCommand.py
@@ -46,6 +46,15 @@ class targetCommandTestCase(TestBase):
 
         self.do_target_variable_command('globals')
 
+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
+    def test_target_variable_command_with_dsym_no_fail(self):
+        """Test 'target variable' command before and after starting the inferior."""
+        d = {'C_SOURCES': 'globals.c', 'EXE': 'globals'}
+        self.buildDsym(dictionary=d)
+        self.addTearDownCleanup(dictionary=d)
+
+        self.do_target_variable_command_no_fail('globals')
+
     def do_target_command(self):
         """Exercise 'target create', 'target list', 'target select' commands."""
         exe_a = os.path.join(os.getcwd(), "a.out")
@@ -109,18 +118,78 @@ class targetCommandTestCase(TestBase):
             substrs = ['my_global_str', '"abc"'])
         self.expect("target variable my_static_int", VARIABLES_DISPLAYED_CORRECTLY,
             substrs = ['my_static_int', '228'])
-
+        self.expect("target variable my_global_str_ptr", matching=False,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str_ptr", matching=True,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['a'])
+
+        self.runCmd("b main")
         self.runCmd("run")
+        
+        self.expect("target variable my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['my_global_str', '"abc"'])
+        self.expect("target variable my_static_int", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['my_static_int', '228'])
+        self.expect("target variable my_global_str_ptr", matching=False,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str_ptr", matching=True,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['a'])
+        self.expect("target variable my_global_char", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ["my_global_char", "'X'"])
+
+        self.runCmd("c")
 
         # rdar://problem/9763907
         # 'target variable' command fails if the target program has been run
+        self.expect("target variable my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+            substrs = ['my_global_str', '"abc"'])
+        self.expect("target variable my_static_int", VARIABLES_DISPLAYED_CORRECTLY,
+            substrs = ['my_static_int', '228'])
+        self.expect("target variable my_global_str_ptr", matching=False,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str_ptr", matching=True,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['a'])
+        self.expect("target variable my_global_char", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ["my_global_char", "'X'"])
+
+    def do_target_variable_command_no_fail(self, exe_name):
+        """Exercise 'target variable' command before and after starting the inferior."""
+        self.runCmd("file " + exe_name, CURRENT_EXECUTABLE_SET)
+
         self.expect("target variable my_global_char", VARIABLES_DISPLAYED_CORRECTLY,
             substrs = ["my_global_char", "'X'"])
         self.expect("target variable my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
             substrs = ['my_global_str', '"abc"'])
         self.expect("target variable my_static_int", VARIABLES_DISPLAYED_CORRECTLY,
             substrs = ['my_static_int', '228'])
-
+        self.expect("target variable my_global_str_ptr", matching=False,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str_ptr", matching=True,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['a'])
+
+        self.runCmd("b main")
+        self.runCmd("run")
+        
+        self.expect("target variable my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['my_global_str', '"abc"'])
+        self.expect("target variable my_static_int", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['my_static_int', '228'])
+        self.expect("target variable my_global_str_ptr", matching=False,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str_ptr", matching=True,
+                    substrs = ['"abc"'])
+        self.expect("target variable *my_global_str", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ['a'])
+        self.expect("target variable my_global_char", VARIABLES_DISPLAYED_CORRECTLY,
+                    substrs = ["my_global_char", "'X'"])
 
 if __name__ == '__main__':
     import atexit