diff options
| author | Pavel Labath <pavel@labath.sk> | 2024-12-03 10:21:04 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-03 10:21:04 +0100 |
| commit | ba14dac481564000339ba22ab867617590184f4c (patch) | |
| tree | 1b6ea50a35668c56a8b6fd8ec96db916789d5eda /lldb/test/Shell/SymbolFile/PDB | |
| parent | 89a0ee89973c3d213c4bc11c26b41eab67e06da0 (diff) | |
[lldb] Use the function block as a source for function ranges (#117996)
This is a follow-up/reimplementation of #115730. While working on that
patch, I did not realize that the correct (discontinuous) set of ranges
is already stored in the block representing the whole function. The
catch -- ranges for this block are only set later, when parsing all of
the blocks of the function.
This patch changes that by populating the function block ranges eagerly
-- from within the Function constructor. This also necessitates a
corresponding change in all of the symbol files -- so that they stop
populating the ranges of that block. This allows us to avoid some
unnecessary work (not parsing the function DW_AT_ranges twice) and also
results in some simplification of the parsing code.
Diffstat (limited to 'lldb/test/Shell/SymbolFile/PDB')
| -rw-r--r-- | lldb/test/Shell/SymbolFile/PDB/function-nested-block.test | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lldb/test/Shell/SymbolFile/PDB/function-nested-block.test b/lldb/test/Shell/SymbolFile/PDB/function-nested-block.test index 1cb20a403638..9057d01c2584 100644 --- a/lldb/test/Shell/SymbolFile/PDB/function-nested-block.test +++ b/lldb/test/Shell/SymbolFile/PDB/function-nested-block.test @@ -2,7 +2,6 @@ REQUIRES: system-windows, lld RUN: %build --compiler=clang-cl --nodefaultlib --output=%t.exe %S/Inputs/FunctionNestedBlockTest.cpp RUN: lldb-test symbols -find=function -file FunctionNestedBlockTest.cpp -line 4 %t.exe | FileCheck --check-prefix=CHECK-FUNCTION %s RUN: lldb-test symbols -find=block -file FunctionNestedBlockTest.cpp -line 4 %t.exe | FileCheck --check-prefix=CHECK-BLOCK %s -XFAIL: * CHECK-FUNCTION: Found 1 functions: CHECK-FUNCTION: name = "{{.*}}", mangled = "{{_?}}main" |