diff options
| author | Adrian Prantl <aprantl@apple.com> | 2024-09-27 16:32:35 -0700 |
|---|---|---|
| committer | Adrian Prantl <aprantl@apple.com> | 2024-09-27 18:09:52 -0700 |
| commit | d33fa70dddcb29d5fd85188e119f034e585ccccf (patch) | |
| tree | 77285a9be170a11e3885dcf4bdb02959457ced16 /lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py | |
| parent | df4d7d3b29b073e24a5ebb8302e7a1ac873a5cde (diff) | |
[lldb] Inline expression evaluator error visualization (#106470)
This patch is a reworking of Pete Lawrence's (@PortalPete) proposal
for better expression evaluator error messages:
https://github.com/llvm/llvm-project/pull/80938
Before:
```
$ lldb -o "expr a+b"
(lldb) expr a+b
error: <user expression 0>:1:1: use of undeclared identifier 'a'
a+b
^
error: <user expression 0>:1:3: use of undeclared identifier 'b'
a+b
^
```
After:
```
(lldb) expr a+b
^ ^
│ ╰─ error: use of undeclared identifier 'b'
╰─ error: use of undeclared identifier 'a'
```
This eliminates the confusing `<user expression 0>:1:3` source
location and avoids echoing the expression to the console again, which
results in a cleaner presentation that makes it easier to grasp what's
going on. You can't see it here, bug the word "error" is now also in
color, if so desired.
Depends on https://github.com/llvm/llvm-project/pull/106442.
Diffstat (limited to 'lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py')
| -rw-r--r-- | lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py b/lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py index 71df90e6a6d1..3be93dedfd11 100644 --- a/lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py +++ b/lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py @@ -21,7 +21,8 @@ class TemplateFunctionsTestCase(TestBase): "expr b1 <=> b2", error=True, substrs=[ - "warning: <user expression 0>:1:4: '<=>' is a single token in C++20; add a space to avoid a change in behavior" + "warning:", + "'<=>' is a single token in C++20; add a space to avoid a change in behavior", ], ) |
