diff options
| author | Med Ismail Bennani <medismail.bennani@gmail.com> | 2022-11-18 13:53:57 -0800 |
|---|---|---|
| committer | Med Ismail Bennani <medismail.bennani@gmail.com> | 2022-11-18 13:56:48 -0800 |
| commit | 7e01924e4e5634a6fa7d500574aeca58c8f36873 (patch) | |
| tree | 564584938cc29e0de71ad0b4682da79f5617ffba /lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py | |
| parent | 288843a161f71148d7028e5153038006dd87e363 (diff) | |
[lldb/Plugins] Improve error reporting with reading memory in Scripted Process
This patch improves the ScriptedPythonInterface::Dispatch method to
support passing lldb_private types to the python implementation.
This will allow, for instance, the Scripted Process python implementation
to report errors when reading memory back to lldb.
To do so, the Dispatch method will transform the private types in the
parameter pack into `PythonObject`s to be able to pass them down to the
python methods.
Then, if the call succeeded, the transformed arguments will be converted
back to their original type and re-assigned in the parameter pack, to
ensure pointers and references behaviours are preserved.
This patch also updates various scripted process python class and tests
to reflect this change.
rdar://100030995
Differential Revision: https://reviews.llvm.org/D134033
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Diffstat (limited to 'lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py')
| -rw-r--r-- | lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py b/lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py index a687870e1f89..d4f795390734 100644 --- a/lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py +++ b/lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py @@ -20,11 +20,12 @@ class DummyScriptedProcess(ScriptedProcess): def get_registers_for_thread(self, tid: int): return {} - def read_memory_at_address(self, addr: int, size: int) -> lldb.SBData: + def read_memory_at_address(self, addr: int, size: int, error: lldb.SBError) -> lldb.SBData: data = lldb.SBData().CreateDataFromCString( self.target.GetByteOrder(), self.target.GetCodeByteSize(), "Hello, world!") + return data def get_loaded_images(self): |
