summaryrefslogtreecommitdiff
path: root/lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py
diff options
context:
space:
mode:
authorDevon Loehr <DKLoehr@users.noreply.github.com>2025-02-28 04:25:55 -0500
committerGitHub <noreply@github.com>2025-02-28 10:25:55 +0100
commit751f2fc8d5f465be5634b39adb8256a02f419984 (patch)
treeac3e85899f251b14a8fe72937d5b491895b9f9c0 /lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py
parenta278b28a945a8354627303604671a28751f3ca51 (diff)
Disable unique-object-duplication warning in templates (#129120)
I've been trying to resolve instances of the unique-object-duplication warning in chromium code. Unfortunately, I've found that practically speaking, it's near-impossible to actually fix the problem when templates are involved. My understanding is that the warning is correct -- the variables it's flagging are indeed duplicated and potentially causing bugs as a result. The problem is that hiddenness is contagious: if a templated class or variable depends on something hidden, then it itself must also be hidden, even if the user explicitly marked it visible. In order to make it actually visible, the user must manually figure out everything that it depends on, mark them as visible, and do so recursively until all of its ancestors are visible. This process is extremely difficult and unergonomic, negating much of the benefits of templates since now each new use requires additional work. Furthermore, the process doesn't work if the user can't edit some of the files, e.g. if they're in a third-party library. Since a warning that can't practically be fixed isn't useful, this PR disables the warning for _all_ templated code by inverting the check. The warning remains active (and, in my experience, easily fixable) in non-templated code.
Diffstat (limited to 'lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py')
0 files changed, 0 insertions, 0 deletions