diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2024-02-15 23:43:37 -0800 |
|---|---|---|
| committer | Jonas Devlieghere <jonas@devlieghere.com> | 2024-02-16 07:59:03 -0800 |
| commit | bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f (patch) | |
| tree | 0c95dac4472cd14bcd992d7789c51e35c879dfdd /lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py | |
| parent | 3363d23bd39970cbd5e32bfca6892ffd97ceb023 (diff) | |
[lldb] Fix and rename skipIfHostIncompatibleWithRemote
Fix and rename the broken and confusingly named decorator
skipIfHostIncompatibleWithRemote. The decorator is meant to skip test
which uses the inferior test build system (i.e. to build test inferiors)
to build host binaries (e.g. lldb drivers).
The decorator was broken on macOS, where the host and target platform
report macosx, but the decorator overwrote it with Darwin, resulting in
tests incorrectly being skipped.
The decorator was also missing on a handful of tests that use the
buildDriver helper, which this commit fixes as well.
Diffstat (limited to 'lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py')
| -rw-r--r-- | lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py b/lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py index 46ebbef5c3ab..d2df036683bf 100644 --- a/lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py +++ b/lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py @@ -13,9 +13,7 @@ class PluginCommandTestCase(TestBase): TestBase.setUp(self) @skipIfNoSBHeaders - # Requires a compatible arch and platform to link against the host's built - # lldb lib. - @skipIfHostIncompatibleWithRemote + @skipIfHostIncompatibleWithTarget @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778") @no_debug_info_test def test_load_plugin(self): |