diff options
| author | Jason Molenda <jason@molenda.com> | 2023-09-18 22:48:46 -0700 |
|---|---|---|
| committer | Jason Molenda <jason@molenda.com> | 2023-09-18 22:50:39 -0700 |
| commit | 44532a9dd4a0ed08850dbddf80b7abcc51c4a7f1 (patch) | |
| tree | b329bf0fa69ea63413066177e14435cd7c788f41 /lldb/source/Target/Target.cpp | |
| parent | af935cf0ee8a26dcf0860ed0c72d74b4a1cb1314 (diff) | |
Revert "[lldb] Add 'modify' type watchpoints, make it default (#66308)"
TestStepOverWatchpoint.py and TestUnalignedWatchpoint.py are failing
on the ubuntu and debian bots
https://lab.llvm.org/buildbot/#/builders/68/builds/60204
https://lab.llvm.org/buildbot/#/builders/96/builds/45623
and the newly added test TestModifyWatchpoint.py does not
work on windows bot
https://lab.llvm.org/buildbot/#/builders/219/builds/5708
I will debug tomorrow morning and reland.
This reverts commit 3692267ca8f9c51cb55e4387283762d921fe2ae2.
Diffstat (limited to 'lldb/source/Target/Target.cpp')
| -rw-r--r-- | lldb/source/Target/Target.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index f197b1b1aa09..8de4fd033ec8 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -860,8 +860,7 @@ WatchpointSP Target::CreateWatchpoint(lldb::addr_t addr, size_t size, size_t old_size = matched_sp->GetByteSize(); uint32_t old_type = (matched_sp->WatchpointRead() ? LLDB_WATCH_TYPE_READ : 0) | - (matched_sp->WatchpointWrite() ? LLDB_WATCH_TYPE_WRITE : 0) | - (matched_sp->WatchpointModify() ? LLDB_WATCH_TYPE_MODIFY : 0); + (matched_sp->WatchpointWrite() ? LLDB_WATCH_TYPE_WRITE : 0); // Return the existing watchpoint if both size and type match. if (size == old_size && kind == old_type) { wp_sp = matched_sp; |