diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2023-07-29 11:15:42 +0200 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2023-07-29 11:21:22 +0200 |
| commit | ed23609bc2adcf3c9b4a446d7a74580adfa76092 (patch) | |
| tree | c754b5b7f3e88fa22f42f8718f2792c83629714e /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | |
| parent | ff80fc0ea2f9ec043d679f343c875bdf43e1395e (diff) | |
[PatternMatch] Do not match constant expressions for binops
Currently, m_Mul() style matchers also match constant expressions.
This is a regular source of assertion failures (usually by trying
to do a match and then cast to Instruction or BinaryOperator) and
infinite combine loops. At the same time, I don't think this provides
useful optimization capabilities (all of the tests affected here are
regression tests for crashes / infinite loops).
Long term, all of these constant expressions (apart from possibly
add/sub) are slated for removal per
https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179
-- but doing those removals can itself expose new crashes and
infinite loops due to the current PatternMatch behavior.
Differential Revision: https://reviews.llvm.org/D156401
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp')
0 files changed, 0 insertions, 0 deletions