diff options
| author | apple-fcloutier <75502309+apple-fcloutier@users.noreply.github.com> | 2024-10-30 20:34:38 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-30 20:34:38 -0700 |
| commit | 97788089988a2ace63d717cadbcfe3443f380f9c (patch) | |
| tree | 940a661185e34c9b4499e8446d0ef39578f5f141 /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | |
| parent | 75aaa312ffa9aa044b84bd1b32491937795c110a (diff) | |
[ObjC] Insert method parameters in scope as they are parsed (#113745)
Before this change, ParseObjc would call the closing
`MaybeParseAttributes` before it had created Objective-C `ParmVarDecl`
objects (and associated name lookup entries), meaning that you could not
reference Objective-C method parameters in
`__attribute__((diagnose_if))`. This change moves the creation of the
`ParmVarDecl` objects ahead of calling `Sema::ActOnMethodDeclaration` so
that `MaybeParseAttributes` can find them. This is already how it works
for C parameters hanging off of the selector.
This change alone is insufficient to enable `diagnose_if` for
Objective-C methods and effectively is NFC. There will be a follow-up PR
for diagnose_if. This change is still useful for any other work that may
need attributes to reference Objective-C parameters.
rdar://138596211
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp')
0 files changed, 0 insertions, 0 deletions
