diff options
| author | Peter Smith <peter.smith@arm.com> | 2020-04-01 08:43:07 +0100 |
|---|---|---|
| committer | Peter Smith <peter.smith@arm.com> | 2020-04-07 09:50:56 +0100 |
| commit | 14c1e987546ef161769aa619bb9de21c943721ec (patch) | |
| tree | daf4981581cddfd7dfc53ffe0f3e8e0b1cadc1fb /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | |
| parent | 70da33bf30dabf9d3c1cddc8d18094f76ff860bb (diff) | |
[ARM] Remove condition that could never be true
From Arm v8 Architecture Reference Manual F5.1.84 LDREXD
The ldrexd instruction in Arm state has the following conditions:
t = UInt(Rt); t2 = t + 1; n = UInt(Rn);
if Rt<0> == '1' || t2 == 15 || n == 15 then UNPREDICTABLE;
In when Rt is odd or if Rt is 14 (making t2 15).
In the implementation when the pair is the UNPREDICTABLE R14_R15 we
would ideally return SOFT_FAIL. We can't because there is no R14_R15
value for us to return so we fail early returning FAIL.
The early return for registers outside the bounds of the table means
the check for Rt == 14 (0xE) redundant which causes a static analyzer
to flag the condition as never being true.
To fix the warning I've removed the check and replaced with a comment
explaining the difference with the specification.
Fixes pr41660
Differential Revision: https://reviews.llvm.org/D77463
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp')
0 files changed, 0 insertions, 0 deletions
