diff options
| author | Ingo Müller <ingomueller@google.com> | 2023-08-31 08:03:54 +0000 |
|---|---|---|
| committer | Ingo Müller <ingomueller@google.com> | 2023-09-01 07:35:54 +0000 |
| commit | 9f5335487ae559a5f7976f1c3cb92ded2b123016 (patch) | |
| tree | eb56bcfcae8f659d6fd1bacef1bccf8951613a27 /lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp | |
| parent | dd48a9b0561cc65b8597d618f8b286682866c66d (diff) | |
[mlir][python] Remove __str__ from bindings of StringAttr.
This reverts a feature introduced in commit
2a5d497494c24425e99655b85e2277dd3f15a400. The goal of that commit was to
allow `StringAttr`s to by used transparently wherever Python `str`s are
expected. But, as the tests in https://reviews.llvm.org/D159182 reveal,
pybind11 doesn't do this conversion based on `__str__` automatically,
unlike for the other types introduced in the commit above. At the same
time, changing `__str__` breaks the symmetry with other attributes of
`print(attr)` printing the assembly of the attribute, so the change
probably has more disadvantages than advantages.
Reviewed By: springerm, rkayaith
Differential Revision: https://reviews.llvm.org/D159255
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp')
0 files changed, 0 insertions, 0 deletions