diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2018-07-24 16:00:55 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2018-07-24 16:00:55 +0000 |
| commit | 33b78c5d24ecafeff93d9345e7dc21c9005985d6 (patch) | |
| tree | 8c4b1967bbba7d092d09073a25413e97839b5521 /lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp | |
| parent | f8f2a788f06ea811503dbf035b0de182e2700b04 (diff) | |
[VFS] Cleanups to VFS interfaces.
Summary:
- add comments clarifying semantics
- Status::copyWithNewName(Status, Name) --> instance method
- Status::copyWithNewName(fs::file_status, Name) --> constructor (it's not a copy)
- File::getName() -> getRealPath(), reflecting its actual behavior/function
and stop returning status().getName() in the base class (callers can do this
fallback if they want to, it complicates the contracts).
This is mostly NFC, but the behavior of File::getName() affects FileManager's
FileEntry::tryGetRealPathName(), which now fails in more cases:
- non-real file cases
- real-file cases where the underlying vfs::File was opened in a way that
doesn't call realpath().
(In these cases we don't know a distinct real name, so in principle it seems OK)
Reviewers: klimek
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D49724
llvm-svn: 337834
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp')
0 files changed, 0 insertions, 0 deletions