diff options
| author | Alexandre Ganea <alexandre.ganea@ubisoft.com> | 2021-03-24 12:28:00 -0400 |
|---|---|---|
| committer | Alexandre Ganea <alexandre.ganea@ubisoft.com> | 2021-03-24 12:47:08 -0400 |
| commit | 64ab2b6825c5aeae6e4afa7ef0829b89a6828102 (patch) | |
| tree | bf3fe2858bd383e1129285f813124d0a45c0aa6d /lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp | |
| parent | 7d91d81c6b6a456ca2362b691485c8e1b42809dd (diff) | |
[Support] Fix 'keeping' temporary files on Windows 7
As reported here: https://bugs.llvm.org/show_bug.cgi?id=48378#c0
and here: https://github.com/rust-lang/rust/issues/81051
since 79657e2339b58bc01fe1b85a448bb073d57d90bb, some programs such as llvm-ar
don't work properly on Windows 7.
The issue is shown in the snippet by Oleksandr Prodan:
https://pastebin.com/v51m3uBU
In essence, once the 'DeleteFile' flag has been set on FILE_DISPOSITION_INFO,
the file path can't be queried anymore with GetFinalPathNameByHandleW. This
however works on Windows 10, GetFinalPathNameByHandleW would return sucessfully.
To workaround the issue, we simply reset the 'DeleteFile' flag before even
checking if we're dealing with a network file.
Tested with `llvm-ar r empty.a a.obj` ran on a network mount. At the moment, we
cannot specifically add a test coverage for this, since it requres mounting a
network drive.
Diffstat (limited to 'lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp')
0 files changed, 0 insertions, 0 deletions