diff options
| author | Guillaume Chatelet <gchatelet@google.com> | 2024-01-26 15:18:22 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-26 15:18:22 +0100 |
| commit | 73874f7a39df74eacf1682b3961da2d8cb675f33 (patch) | |
| tree | 275fdfa7b0f4e03dbe36a9c4451ad658ad2d9b2e /libc/test/src/sys/stat/fchmod_test.cpp | |
| parent | 035f33bf4138ac7b7360a83438988ce80bda5098 (diff) | |
[libc][NFC] Use specific ASSERT macros to test errno (#79573)
This patch provides specific test macros to deal with `errno`.
This will help abstract away the differences between unit test and integration/hermetic tests in #79319.
In one case we use `libc_errno` which is a struct, in the other case we deal directly with `errno`.
Diffstat (limited to 'libc/test/src/sys/stat/fchmod_test.cpp')
| -rw-r--r-- | libc/test/src/sys/stat/fchmod_test.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/libc/test/src/sys/stat/fchmod_test.cpp b/libc/test/src/sys/stat/fchmod_test.cpp index 5a32b5c973db..a0a93b03d22e 100644 --- a/libc/test/src/sys/stat/fchmod_test.cpp +++ b/libc/test/src/sys/stat/fchmod_test.cpp @@ -32,25 +32,25 @@ TEST(LlvmLibcChmodTest, ChangeAndOpen) { int fd = LIBC_NAMESPACE::open(TEST_FILE, O_APPEND | O_WRONLY); ASSERT_GT(fd, 0); - ASSERT_EQ(libc_errno, 0); + ASSERT_ERRNO_SUCCESS(); ASSERT_EQ(LIBC_NAMESPACE::write(fd, WRITE_DATA, sizeof(WRITE_DATA)), WRITE_SIZE); ASSERT_THAT(LIBC_NAMESPACE::close(fd), Succeeds(0)); fd = LIBC_NAMESPACE::open(TEST_FILE, O_APPEND | O_WRONLY); ASSERT_GT(fd, 0); - ASSERT_EQ(libc_errno, 0); + ASSERT_ERRNO_SUCCESS(); EXPECT_THAT(LIBC_NAMESPACE::fchmod(fd, S_IRUSR), Succeeds(0)); ASSERT_THAT(LIBC_NAMESPACE::close(fd), Succeeds(0)); // Opening for writing should fail. EXPECT_EQ(LIBC_NAMESPACE::open(TEST_FILE, O_APPEND | O_WRONLY), -1); - EXPECT_NE(libc_errno, 0); + ASSERT_ERRNO_FAILURE(); libc_errno = 0; // But opening for reading should succeed. fd = LIBC_NAMESPACE::open(TEST_FILE, O_APPEND | O_RDONLY); EXPECT_GT(fd, 0); - EXPECT_EQ(libc_errno, 0); + ASSERT_ERRNO_SUCCESS(); EXPECT_THAT(LIBC_NAMESPACE::fchmod(fd, S_IRWXU), Succeeds(0)); EXPECT_THAT(LIBC_NAMESPACE::close(fd), Succeeds(0)); @@ -59,6 +59,6 @@ TEST(LlvmLibcChmodTest, ChangeAndOpen) { TEST(LlvmLibcChmodTest, NonExistentFile) { libc_errno = 0; ASSERT_EQ(LIBC_NAMESPACE::fchmod(-1, S_IRUSR), -1); - ASSERT_NE(libc_errno, 0); + ASSERT_ERRNO_FAILURE(); libc_errno = 0; } |
