diff options
| author | Aiden Grossman <aidengrossman@google.com> | 2025-11-17 15:21:10 +0000 |
|---|---|---|
| committer | Aiden Grossman <aidengrossman@google.com> | 2025-11-18 00:21:06 +0000 |
| commit | eb20b5392599996ce94e4c0392095cacaa33687c (patch) | |
| tree | 3edba1ddb54045cddf5b33aa9bc8ce51659f158a /compiler-rt | |
| parent | 2c4bce4048c55aede9eb927a41d5be3283f0f33d (diff) | |
Revert "Reapply "[compiler-rt] Default to Lit's Internal Shell" (#168232)"
This reverts commit bde90624185ea2cead0a8d7231536e2625d78798.
This caused failures on Darwin that were not caught by upstream
buildbots. Reverting for now to give myself some time to fix.
Diffstat (limited to 'compiler-rt')
| -rw-r--r-- | compiler-rt/test/lit.common.cfg.py | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/compiler-rt/test/lit.common.cfg.py b/compiler-rt/test/lit.common.cfg.py index 0f0f87915baf..3f7dd8e402b7 100644 --- a/compiler-rt/test/lit.common.cfg.py +++ b/compiler-rt/test/lit.common.cfg.py @@ -113,9 +113,6 @@ def push_dynamic_library_lookup_path(config, new_path): config.environment[dynamic_library_lookup_var] = new_ld_library_path_64 -# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites. -# See https://github.com/llvm/llvm-project/issues/106636 for more details. -# # Choose between lit's internal shell pipeline runner and a real shell. If # LIT_USE_INTERNAL_SHELL is in the environment, we use that as an override. use_lit_shell = os.environ.get("LIT_USE_INTERNAL_SHELL") @@ -123,8 +120,9 @@ if use_lit_shell: # 0 is external, "" is default, and everything else is internal. execute_external = use_lit_shell == "0" else: - # Otherwise we default to internal everywhere. - execute_external = False + # Otherwise we default to internal on Windows and external elsewhere, as + # bash on Windows is usually very slow. + execute_external = not sys.platform in ["win32"] # Allow expanding substitutions that are based on other substitutions config.recursiveExpansionLimit = 10 |