summaryrefslogtreecommitdiff
path: root/clang/lib/CodeGen/CGExprScalar.cpp
diff options
context:
space:
mode:
authorCHANDRA GHALE <chandra.nitdgp@gmail.com>2025-09-11 16:31:38 +0530
committerGitHub <noreply@github.com>2025-09-11 16:31:38 +0530
commit2f755c543ab357bd83235592fcee37fa391cdd9d (patch)
tree2393978c849e76afa0ee299b26131714950b6488 /clang/lib/CodeGen/CGExprScalar.cpp
parente7429c2e10b1e30a0b1a18cc7290ab95a7e83b6a (diff)
[OpenMP] Conditional modifier on lastprivate clause is producing incorrect result in C mode (#156004)
Conditional modifier on lastprivate clause is producing incorrect result when compiled with clang( C compiler). IR is not emitting while compilation with C compiler. However it is working correctly with clang++ The OpenMP hook that emits the conditional modifier (checkAndEmitLastprivateConditional) is skipped in C because assignment is a prvalue and takes the scalar path. Original Codegen Support : [eddb8](https://github.com/llvm/llvm-project/commit/a58da1a2ff039dd3bb4c43db3919995cf4a74cc7#diff-629e03f730f901cdf96b6b48fb0aed8ef156590aaff37857b8e5ad0694beddb8) ``` C = → prvalue → EmitAnyExpr(TEK_Scalar) → ScalarExprEmitter::VisitBinAssign (hook not reached) C++ = → lvalue → EmitBinaryOperatorLValue ``` ``` Failing Test Case : #include <stdio.h> #define N 10 int A[N]; void condlastprivate() { int x, y, z, k; x = y = z = k = 0; #pragma omp parallel for lastprivate(conditional: x,y, z) lastprivate(k) for( k=0; k<N; k++){ if ((k >2 ) && (k <6)) { x = A[k]; z = A[k]+111; } else { y = A[k]+222; } } printf("Expecting: x=5, y=231, z=116 k=10 Got: x=%d y=%d z=%d k=%d \n", x,y,z,k); } int main() { for( int i=0; i<N; i++) { A[i] = i; } condlastprivate(); return 0; } ``` ``` #>./clang -fopenmp cond_c.c #> ./a.out Expecting: x=5, y=231, z=116 k=10 **Got: x=-1376379760 y=231 z=631465600** k=10 ``` --------- Co-authored-by: Chandra Ghale <ghale@pe31.hpc.amslabs.hpecorp.net>
Diffstat (limited to 'clang/lib/CodeGen/CGExprScalar.cpp')
-rw-r--r--clang/lib/CodeGen/CGExprScalar.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp
index 2eff3a387593..ce483c5cc4e4 100644
--- a/clang/lib/CodeGen/CGExprScalar.cpp
+++ b/clang/lib/CodeGen/CGExprScalar.cpp
@@ -5216,6 +5216,11 @@ Value *ScalarExprEmitter::VisitBinAssign(const BinaryOperator *E) {
CGF.EmitStoreThroughLValue(RValue::get(RHS), LHS);
}
}
+ // OpenMP: Handle lastprivate(condition:) in scalar assignment
+ if (CGF.getLangOpts().OpenMP) {
+ CGF.CGM.getOpenMPRuntime().checkAndEmitLastprivateConditional(CGF,
+ E->getLHS());
+ }
// If the result is clearly ignored, return now.
if (Ignore)