summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjjasmine <jjasmine@igalia.com>2025-07-01 15:27:37 -0700
committerGitHub <noreply@github.com>2025-07-01 15:27:37 -0700
commite9c9f8f3748a1666dfd099da7990ebe4523778bf (patch)
treec86bc678997c524bc45ba7b1ebb03453d42bec9d
parent4a8c1f7d127af06642068da56e29178704caf54d (diff)
[WebAssembly] Fold any/alltrue (setcc x, 0, eq/ne) to [not] any/alltrue x (#144741)
Fixes https://github.com/llvm/llvm-project/issues/50142, a miss of further vectorization, where we can only achieve zext (xor (any_true), -1). Now in test case simd-setcc-reductions, it's converted to all_true. Also fixes https://github.com/llvm/llvm-project/issues/145177, which is all_true (setcc x, 0, eq) -> not any_true any_true (setcc x, 0, ne) -> any_true all_true (setcc x, 0, ne) -> all_true --------- Co-authored-by: badumbatish <--show-origin>
-rw-r--r--llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp58
-rw-r--r--llvm/test/CodeGen/WebAssembly/simd-setcc-reductions.ll135
-rw-r--r--llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll6
3 files changed, 195 insertions, 4 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
index 0ee1163eb7cf..dfbf6cfb3ff4 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
@@ -3286,6 +3286,59 @@ static SDValue performBitcastCombine(SDNode *N,
return SDValue();
}
+static SDValue performAnyAllCombine(SDNode *N, SelectionDAG &DAG) {
+ // any_true (setcc <X>, 0, eq) => (not (all_true X))
+ // all_true (setcc <X>, 0, eq) => (not (any_true X))
+ // any_true (setcc <X>, 0, ne) => (any_true X)
+ // all_true (setcc <X>, 0, ne) => (all_true X)
+ assert(N->getOpcode() == ISD::INTRINSIC_WO_CHAIN);
+ using namespace llvm::SDPatternMatch;
+
+ SDValue LHS;
+ if (!sd_match(N->getOperand(1),
+ m_c_SetCC(m_Value(LHS), m_Zero(), m_CondCode())))
+ return SDValue();
+ EVT LT = LHS.getValueType();
+ if (LT.getScalarSizeInBits() > 128 / LT.getVectorNumElements())
+ return SDValue();
+
+ auto CombineSetCC = [&N, &DAG](Intrinsic::WASMIntrinsics InPre,
+ ISD::CondCode SetType,
+ Intrinsic::WASMIntrinsics InPost) {
+ if (N->getConstantOperandVal(0) != InPre)
+ return SDValue();
+
+ SDValue LHS;
+ if (!sd_match(N->getOperand(1), m_c_SetCC(m_Value(LHS), m_Zero(),
+ m_SpecificCondCode(SetType))))
+ return SDValue();
+
+ SDLoc DL(N);
+ SDValue Ret = DAG.getZExtOrTrunc(
+ DAG.getNode(ISD::INTRINSIC_WO_CHAIN, DL, MVT::i32,
+ {DAG.getConstant(InPost, DL, MVT::i32), LHS}),
+ DL, MVT::i1);
+ if (SetType == ISD::SETEQ)
+ Ret = DAG.getNOT(DL, Ret, MVT::i1);
+ return DAG.getZExtOrTrunc(Ret, DL, N->getValueType(0));
+ };
+
+ if (SDValue AnyTrueEQ = CombineSetCC(Intrinsic::wasm_anytrue, ISD::SETEQ,
+ Intrinsic::wasm_alltrue))
+ return AnyTrueEQ;
+ if (SDValue AllTrueEQ = CombineSetCC(Intrinsic::wasm_alltrue, ISD::SETEQ,
+ Intrinsic::wasm_anytrue))
+ return AllTrueEQ;
+ if (SDValue AnyTrueNE = CombineSetCC(Intrinsic::wasm_anytrue, ISD::SETNE,
+ Intrinsic::wasm_anytrue))
+ return AnyTrueNE;
+ if (SDValue AllTrueNE = CombineSetCC(Intrinsic::wasm_alltrue, ISD::SETNE,
+ Intrinsic::wasm_alltrue))
+ return AllTrueNE;
+
+ return SDValue();
+}
+
template <int MatchRHS, ISD::CondCode MatchCond, bool RequiresNegate,
Intrinsic::ID Intrin>
static SDValue TryMatchTrue(SDNode *N, EVT VecVT, SelectionDAG &DAG) {
@@ -3474,8 +3527,11 @@ WebAssemblyTargetLowering::PerformDAGCombine(SDNode *N,
return performVectorTruncZeroCombine(N, DCI);
case ISD::TRUNCATE:
return performTruncateCombine(N, DCI);
- case ISD::INTRINSIC_WO_CHAIN:
+ case ISD::INTRINSIC_WO_CHAIN: {
+ if (auto AnyAllCombine = performAnyAllCombine(N, DCI.DAG))
+ return AnyAllCombine;
return performLowerPartialReduction(N, DCI.DAG);
+ }
case ISD::MUL:
return performMulCombine(N, DCI.DAG);
}
diff --git a/llvm/test/CodeGen/WebAssembly/simd-setcc-reductions.ll b/llvm/test/CodeGen/WebAssembly/simd-setcc-reductions.ll
new file mode 100644
index 000000000000..172ff53bfb45
--- /dev/null
+++ b/llvm/test/CodeGen/WebAssembly/simd-setcc-reductions.ll
@@ -0,0 +1,135 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc < %s -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+simd128 | FileCheck %s
+
+target triple = "wasm64"
+
+define i32 @all_true_16_i8(<16 x i8> %v) {
+; CHECK-LABEL: all_true_16_i8:
+; CHECK: .functype all_true_16_i8 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: i8x16.all_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp eq <16 x i8> %v, zeroinitializer
+ %2 = bitcast <16 x i1> %1 to i16
+ %3 = icmp eq i16 %2, 0
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
+define i32 @all_true_4_i32(<4 x i32> %v) {
+; CHECK-LABEL: all_true_4_i32:
+; CHECK: .functype all_true_4_i32 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: i32x4.all_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp eq <4 x i32> %v, zeroinitializer
+ %2 = bitcast <4 x i1> %1 to i4
+ %3 = icmp eq i4 %2, 0
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
+define i32 @all_true_8_i16(<8 x i16> %v) {
+; CHECK-LABEL: all_true_8_i16:
+; CHECK: .functype all_true_8_i16 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: i16x8.all_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp eq <8 x i16> %v, zeroinitializer
+ %2 = bitcast <8 x i1> %1 to i8
+ %3 = icmp eq i8 %2, 0
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
+define i32 @all_true_2_i64(<2 x i64> %v) {
+; CHECK-LABEL: all_true_2_i64:
+; CHECK: .functype all_true_2_i64 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: i64x2.all_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp eq <2 x i64> %v, zeroinitializer
+ %2 = bitcast <2 x i1> %1 to i2
+ %3 = icmp eq i2 %2, 0
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
+define i32 @all_true_4_i64(<4 x i64> %v) {
+; CHECK-LABEL: all_true_4_i64:
+; CHECK: .functype all_true_4_i64 (v128, v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: v128.const $push9=, 0, 0
+; CHECK-NEXT: local.tee $push8=, $2=, $pop9
+; CHECK-NEXT: i64x2.eq $push1=, $0, $pop8
+; CHECK-NEXT: i64x2.eq $push0=, $1, $2
+; CHECK-NEXT: i8x16.shuffle $push2=, $pop1, $pop0, 0, 1, 2, 3, 8, 9, 10, 11, 16, 17, 18, 19, 24, 25, 26, 27
+; CHECK-NEXT: v128.any_true $push3=, $pop2
+; CHECK-NEXT: i32.const $push4=, -1
+; CHECK-NEXT: i32.xor $push5=, $pop3, $pop4
+; CHECK-NEXT: i32.const $push6=, 1
+; CHECK-NEXT: i32.and $push7=, $pop5, $pop6
+; CHECK-NEXT: return $pop7
+ %1 = icmp eq <4 x i64> %v, zeroinitializer
+ %2 = bitcast <4 x i1> %1 to i4
+ %3 = icmp eq i4 %2, 0
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
+; setcc (iN (bitcast (set_cc (vNi1 X), 0, ne)), 0, ne
+; => any_true (set_cc (X), 0, ne)
+; => any_true (X)
+define i32 @any_true_1_4_i32(<4 x i32> %v) {
+; CHECK-LABEL: any_true_1_4_i32:
+; CHECK: .functype any_true_1_4_i32 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: v128.any_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp ne <4 x i32> %v, zeroinitializer
+ %2 = bitcast <4 x i1> %1 to i4
+ %3 = icmp ne i4 %2, 0
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+; setcc (iN (bitcast (set_cc (vNi1 X), 0, eq)), -1, ne
+; => not all_true (set_cc (X), 0, eq)
+; => not not any_true (X)
+; => any_true (X)
+define i32 @any_true_2_4_i32(<4 x i32> %v) {
+; CHECK-LABEL: any_true_2_4_i32:
+; CHECK: .functype any_true_2_4_i32 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: v128.any_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp eq <4 x i32> %v, zeroinitializer
+ %2 = bitcast <4 x i1> %1 to i4
+ %3 = icmp ne i4 %2, -1
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
+; setcc (iN (bitcast (set_cc (vNi1 X), 0, ne)), -1, eq
+; => all_true (set_cc (X), 0, ne)
+; => all_true (X)
+define i32 @all_true_2_4_i32(<4 x i32> %v) {
+; CHECK-LABEL: all_true_2_4_i32:
+; CHECK: .functype all_true_2_4_i32 (v128) -> (i32)
+; CHECK-NEXT: # %bb.0:
+; CHECK-NEXT: i32x4.all_true $push0=, $0
+; CHECK-NEXT: return $pop0
+ %1 = icmp ne <4 x i32> %v, zeroinitializer
+ %2 = bitcast <4 x i1> %1 to i4
+ %3 = icmp eq i4 %2, -1
+ %conv3 = zext i1 %3 to i32
+ ret i32 %conv3
+}
+
+
diff --git a/llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll b/llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll
index e6497bca98dc..f7143711394f 100644
--- a/llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll
+++ b/llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll
@@ -1086,9 +1086,9 @@ define i1 @test_cmp_v16i8(<16 x i8> %x) {
; CHECK-LABEL: test_cmp_v16i8:
; CHECK: .functype test_cmp_v16i8 (v128) -> (i32)
; CHECK-NEXT: # %bb.0:
-; CHECK-NEXT: v128.const $push0=, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
-; CHECK-NEXT: i8x16.eq $push1=, $0, $pop0
-; CHECK-NEXT: v128.any_true $push2=, $pop1
+; CHECK-NEXT: i8x16.all_true $push0=, $0
+; CHECK-NEXT: i32.const $push1=, 1
+; CHECK-NEXT: i32.xor $push2=, $pop0, $pop1
; CHECK-NEXT: return $pop2
%zero = icmp eq <16 x i8> %x, zeroinitializer
%ret = call i1 @llvm.vector.reduce.or.v16i1(<16 x i1> %zero)