summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIgor Kudrin <ikudrin@accesssoftek.com>2025-11-20 09:45:54 -0800
committerGitHub <noreply@github.com>2025-11-20 09:45:54 -0800
commitccdb71932aa84a36f3d9689eca97b80bf643c500 (patch)
tree7e8047961cc21603867ee123d89393bef104fe38
parent66ddc9b3e7e22a0c2464c54d96bc30c53ab9cbd1 (diff)
[lldb] Fix a test if hardware breakpoints are not supported (#168813)
If `HardwareBreakpointTestBase.supports_hw_breakpoints()` returns False, `SimpleHWBreakpointTest.does_not_support_hw_breakpoints()` returns None, so the test runs and fails. However, it should be skipped instead. The test was added in #146602, while `supports_hw_breakpoints()` was changed in #146609, which was landed earlier despite having a bigger number.
-rw-r--r--lldb/test/API/functionalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py31
1 files changed, 11 insertions, 20 deletions
diff --git a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py
index ccbb23507c1b..acf75df6711c 100644
--- a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py
+++ b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py
@@ -7,13 +7,7 @@ from functionalities.breakpoint.hardware_breakpoints.base import *
class SimpleHWBreakpointTest(HardwareBreakpointTestBase):
- def does_not_support_hw_breakpoints(self):
- # FIXME: Use HardwareBreakpointTestBase.supports_hw_breakpoints
- if super().supports_hw_breakpoints() is None:
- return "Hardware breakpoints are unsupported"
- return None
-
- @skipTestIfFn(does_not_support_hw_breakpoints)
+ @skipTestIfFn(HardwareBreakpointTestBase.hw_breakpoints_unsupported)
def test(self):
"""Test SBBreakpoint::SetIsHardware"""
self.build()
@@ -35,16 +29,13 @@ class SimpleHWBreakpointTest(HardwareBreakpointTestBase):
# breakpoint will be marked as a hardware breakpoint.
self.assertTrue(break_on_me_bp.IsHardware())
- if super().supports_hw_breakpoints():
- self.assertSuccess(error)
-
- # Continue to our Hardware breakpoint and verify that's the reason
- # we're stopped.
- process.Continue()
- self.expect(
- "thread list",
- STOPPED_DUE_TO_BREAKPOINT,
- substrs=["stopped", "stop reason = breakpoint"],
- )
- else:
- self.assertFailure(error)
+ self.assertSuccess(error)
+
+ # Continue to our Hardware breakpoint and verify that's the reason
+ # we're stopped.
+ process.Continue()
+ self.expect(
+ "thread list",
+ STOPPED_DUE_TO_BREAKPOINT,
+ substrs=["stopped", "stop reason = breakpoint"],
+ )