diff options
| author | Frankie Robertson <frankier@users.noreply.github.com> | 2025-11-21 23:41:29 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-11-21 16:41:29 -0500 |
| commit | 86cbb36b36c15af82a87e89c08fb84792657583d (patch) | |
| tree | 8e7a44d3db5d64d7d601896e4efdeb15f27fd8f5 | |
| parent | 68ba2864d936a59ac1e382f754a15b975b04900d (diff) | |
[lld] Add (ignored) /link flag to lld-link for compatibility with MSVC link.exe (#168364)
Various build tools may produce command lines invoking clang-cl and
lld-link which contain /link twice like so: e.g. `clang-cl.exe
sanitycheckcpp.cc /Fesanitycheckcpp.exe .... /link /link ...`
If link.exe is used, it ignores the extra `/link` and just issues a
warning, however lld-link tries to treat `/link` as a file name.
This PR adds a flag which is ignored in order to improve compatibility
with link.exe
There's some extra context including an "in-the-wild" example and
reproducer of the problem here:
https://github.com/frankier/meson_clang_win_activation
Co-authored-by: Frankie Robertson <frankie@robertson.name>
| -rw-r--r-- | lld/COFF/DriverUtils.cpp | 3 | ||||
| -rw-r--r-- | lld/COFF/Options.td | 1 | ||||
| -rw-r--r-- | lld/test/COFF/driver.test | 3 |
3 files changed, 7 insertions, 0 deletions
diff --git a/lld/COFF/DriverUtils.cpp b/lld/COFF/DriverUtils.cpp index 10a3934d5328..42c7f9338151 100644 --- a/lld/COFF/DriverUtils.cpp +++ b/lld/COFF/DriverUtils.cpp @@ -862,6 +862,9 @@ opt::InputArgList ArgParser::parse(ArrayRef<const char *> argv) { << "', did you mean '" << nearest << "'"; } + if (args.hasArg(OPT_link)) + Warn(ctx) << "ignoring /link, did you pass it multiple times?"; + if (args.hasArg(OPT_lib)) Warn(ctx) << "ignoring /lib since it's not the first argument"; diff --git a/lld/COFF/Options.td b/lld/COFF/Options.td index d77478fc9c98..6c4c7f897513 100644 --- a/lld/COFF/Options.td +++ b/lld/COFF/Options.td @@ -71,6 +71,7 @@ def noimplib : F<"noimplib">, def lib : F<"lib">, HelpText<"Act like lib.exe; must be first argument if present">; def libpath : P<"libpath", "Additional library search path">; +def link : F<"link">, HelpText<"Ignored for compatibility">; def linkrepro : Joined<["/", "-", "/?", "-?"], "linkrepro:">, MetaVarName<"directory">, HelpText<"Write repro.tar containing inputs and command to reproduce link">; diff --git a/lld/test/COFF/driver.test b/lld/test/COFF/driver.test index 8f58ff44e83e..1c265bff75df 100644 --- a/lld/test/COFF/driver.test +++ b/lld/test/COFF/driver.test @@ -17,6 +17,9 @@ LIBHELP: OVERVIEW: LLVM Lib # RUN: env LLD_IN_TEST=1 not lld-link /WX /lib 2>&1 | FileCheck -check-prefix=LIBBAD %s LIBBAD: ignoring /lib since it's not the first argument +# RUN: env LLD_IN_TEST=1 not lld-link /link 2>&1 | FileCheck -check-prefix=LINKBAD %s +LINKBAD: ignoring /link, did you pass it multiple times? + # RUN: yaml2obj %p/Inputs/hello32.yaml -o %t.obj # RUN: not lld-link /out:/ %t.obj 2>&1 | FileCheck -check-prefix=DIR %s DIR: cannot open output file |