summaryrefslogtreecommitdiff
path: root/.github/workflows/containers
diff options
context:
space:
mode:
authorAiden Grossman <aidengrossman@google.com>2025-07-14 10:46:06 -0700
committerGitHub <noreply@github.com>2025-07-14 10:46:06 -0700
commit968b2389ce521e7730e4069760c278c8d2abf0f3 (patch)
tree1c1284f5734f7b8b7be6f6a9f71e5edc4312dcc9 /.github/workflows/containers
parent2244f57130a5bc01f1c7713b6d7d55da926814cf (diff)
[CI][Github] Version pin packages in windows container
I spent several hours debugging failures in the server 2022 container today that turned out to be related to a new ninja release from a couple weeks ago. This patch version pins all the packages so they do not spuriously upgrade and we can control the process to waste less effort debugging changes due to version changes. Reviewers: cmtice, tstellar, lnihlen Reviewed By: cmtice Pull Request: https://github.com/llvm/llvm-project/pull/148319
Diffstat (limited to '.github/workflows/containers')
-rw-r--r--.github/workflows/containers/github-action-ci-windows/Dockerfile9
1 files changed, 7 insertions, 2 deletions
diff --git a/.github/workflows/containers/github-action-ci-windows/Dockerfile b/.github/workflows/containers/github-action-ci-windows/Dockerfile
index 59ba5c2cebf9..b909d14b4eee 100644
--- a/.github/workflows/containers/github-action-ci-windows/Dockerfile
+++ b/.github/workflows/containers/github-action-ci-windows/Dockerfile
@@ -39,11 +39,16 @@ RUN regsvr32 /S "C:\BuildTools\DIA SDK\bin\amd64\msdia140.dll" & \
# install tools as described in https://llvm.org/docs/GettingStartedVS.html
# and a few more that were not documented...
-RUN choco install -y ninja git sccache
# Pin an older version of Python; the current Python 3.10 fails when
# doing "pip install" for the other dependencies, as it fails to find libxml
# while compiling some package.
-RUN choco install -y python3 --version 3.9.7
+# We version pin the other packages as well to ensure the container build is as
+# reproducible as possible to prevent issues when upgrading only part of the
+# container.
+RUN choco install -y ninja --version 1.13.1 && \
+ choco install -y git --version 2.50.1 && \
+ choco install -y sccache --version 0.10.0 && \
+ choco install -y python3 --version 3.9.7
# Testing requires psutil
RUN pip install psutil