ada: Avoid incorrect errors for duplicate formal iterator names

This patch fixes the following bug: If a type has an Iterable aspect
(as in the formal containers), and two or more cursor loops of the
form "for C in ..."  occur in the same scope, and the cursor type has
discriminants without defaults, the compiler complains incorrectly
about duplicate names "Tc".

This is because the generated declaration of the C object was being
analyzed in the wrong scope. In the discriminated case, an internal
subtype name TcS is generated for each C. Errout "helpfully" removes "S"
in the error message, resulting in a complaint about "Tc".  The fix is
to push the correct scope (that of the generated surrounding block
statement) when analyzing the declaration of C.

gcc/ada/ChangeLog:

	* exp_ch5.adb (Expand_Formal_Container_Loop):
	Analyze Init_Decl in the correct scope. Remove patch-up
	code that was needed because we were using the wrong scope.
	* exp_ch7.adb (Process_Object_Declaration):
	Remove code to unique-ify the name of Master_Node_Id;
	no longer needed because of change to exp_ch5.adb.
	* sem_warn.adb (Check_References):
	Suppress warnings during preanalysis, because we don't
	have complete information yet; otherwise, the new Preanalyze
	call in exp_ch5.adb generates bogus warnings.

0 files changed, 0 insertions, 0 deletions