From fc367dfa6770fda4adc4e5de79846f22e7e4e215 Mon Sep 17 00:00:00 2001 From: Mahesh Ravishankar Date: Fri, 11 Nov 2022 17:10:38 +0000 Subject: [mlir] Remove `Transforms/SideEffectUtils.h` and move the methods into `Interface/SideEffectInterfaces.h`. The methods in `SideEffectUtils.h` (and their implementations in `SideEffectUtils.cpp`) seem to have similar intent to methods already existing in `SideEffectInterfaces.h`. Move the decleration (and implementation) from `SideEffectUtils.h` (and `SideEffectUtils.cpp`) into `SideEffectInterfaces.h` (and `SideEffectInterface.cpp`). Also drop the `SideEffectInterface::hasNoEffect` method in favor of `mlir::isMemoryEffectFree` which actually recurses into the operation instead of just relying on the `hasRecursiveMemoryEffectTrait` exclusively. Differential Revision: https://reviews.llvm.org/D137857 --- mlir/lib/Transforms/ControlFlowSink.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'mlir/lib/Transforms/ControlFlowSink.cpp') diff --git a/mlir/lib/Transforms/ControlFlowSink.cpp b/mlir/lib/Transforms/ControlFlowSink.cpp index 1000a79c7162..4e1dfa1c7c83 100644 --- a/mlir/lib/Transforms/ControlFlowSink.cpp +++ b/mlir/lib/Transforms/ControlFlowSink.cpp @@ -19,7 +19,6 @@ #include "mlir/Interfaces/ControlFlowInterfaces.h" #include "mlir/Interfaces/SideEffectInterfaces.h" #include "mlir/Transforms/ControlFlowSinkUtils.h" -#include "mlir/Transforms/SideEffectUtils.h" namespace mlir { #define GEN_PASS_DEF_CONTROLFLOWSINK -- cgit v1.2.3