From bb6df0804ba0a0b0581aec4156138f5144dbcee2 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 8 May 2024 10:33:53 -0700 Subject: [llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (#91441) I'm planning to remove StringRef::equals in favor of StringRef::operator==. - StringRef::operator==/!= outnumber StringRef::equals by a factor of 70 under llvm/ in terms of their usage. - The elimination of StringRef::equals brings StringRef closer to std::string_view, which has operator== but not equals. - S == "foo" is more readable than S.equals("foo"), especially for !Long.Expression.equals("str") vs Long.Expression != "str". --- llvm/lib/FileCheck/FileCheck.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'llvm/lib/FileCheck/FileCheck.cpp') diff --git a/llvm/lib/FileCheck/FileCheck.cpp b/llvm/lib/FileCheck/FileCheck.cpp index 8f80a69c4abd..1719f8ef2b43 100644 --- a/llvm/lib/FileCheck/FileCheck.cpp +++ b/llvm/lib/FileCheck/FileCheck.cpp @@ -374,7 +374,7 @@ Expected Pattern::parseNumericVariableDefinition( Expected> Pattern::parseNumericVariableUse( StringRef Name, bool IsPseudo, std::optional LineNumber, FileCheckPatternContext *Context, const SourceMgr &SM) { - if (IsPseudo && !Name.equals("@LINE")) + if (IsPseudo && Name != "@LINE") return ErrorDiagnostic::get( SM, Name, "invalid pseudo numeric variable '" + Name + "'"); -- cgit v1.2.3