From 39f35038140d2e21023eefcc7acc65c5b68fc77f Mon Sep 17 00:00:00 2001 From: Sean Fertile Date: Tue, 30 Jul 2019 15:37:01 +0000 Subject: Address post commit review comments on revision 366727. Addresses number of comment made on D64652 after commiting: - Reorders function decls in the TargetLoweringObjectFileXCOFF class. - Fix comment in MCSectionXCOFF to include description of external reference csects. - Convert several llvm_unreachables to report_fatal_error - Convert several dyn_casts to casts as they are expected not to fail. - Avoid copying DataLayout object. llvm-svn: 367324 --- llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp') diff --git a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp index a3bf69ae4ef0..ac7c4c50ae4c 100644 --- a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp +++ b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp @@ -1826,7 +1826,7 @@ MCSection *TargetLoweringObjectFileWasm::getStaticDtorSection( //===----------------------------------------------------------------------===// MCSection *TargetLoweringObjectFileXCOFF::getExplicitSectionGlobal( const GlobalObject *GO, SectionKind Kind, const TargetMachine &TM) const { - llvm_unreachable("XCOFF explicit sections not yet implemented."); + report_fatal_error("XCOFF explicit sections not yet implemented."); } MCSection *TargetLoweringObjectFileXCOFF::SelectSectionForGlobal( @@ -1851,7 +1851,7 @@ MCSection *TargetLoweringObjectFileXCOFF::SelectSectionForGlobal( bool TargetLoweringObjectFileXCOFF::shouldPutJumpTableInFunctionSection( bool UsesLabelDifference, const Function &F) const { - llvm_unreachable("TLOF XCOFF not yet implemented."); + report_fatal_error("TLOF XCOFF not yet implemented."); } void TargetLoweringObjectFileXCOFF::Initialize(MCContext &Ctx, @@ -1864,16 +1864,16 @@ void TargetLoweringObjectFileXCOFF::Initialize(MCContext &Ctx, MCSection *TargetLoweringObjectFileXCOFF::getStaticCtorSection( unsigned Priority, const MCSymbol *KeySym) const { - llvm_unreachable("XCOFF ctor section not yet implemented."); + report_fatal_error("XCOFF ctor section not yet implemented."); } MCSection *TargetLoweringObjectFileXCOFF::getStaticDtorSection( unsigned Priority, const MCSymbol *KeySym) const { - llvm_unreachable("XCOFF dtor section not yet implemented."); + report_fatal_error("XCOFF dtor section not yet implemented."); } const MCExpr *TargetLoweringObjectFileXCOFF::lowerRelativeReference( const GlobalValue *LHS, const GlobalValue *RHS, const TargetMachine &TM) const { - llvm_unreachable("XCOFF not yet implemented."); + report_fatal_error("XCOFF not yet implemented."); } -- cgit v1.2.3