From 0c5b6320716b4761f2c4307bc95197be5717d132 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Tue, 13 Jun 2023 13:47:14 -0700 Subject: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64 This patch should address the failure of TestStackCoreScriptedProcess that is happening specifically on x86_64. It turns out that in 1370a1cb5b97, I changed the way we extract integers from a `StructuredData::Dictionary` and in order to get a stop info from the scripted process, we call a method that returns a `SBStructuredData` containing the stop reason data. TestStackCoreScriptedProcess` was failing specifically on x86_64 because the stop info dictionary contains the signal number, that the `Scripted Thread` was trying to extract as a signed integer where it was actually parsed as an unsigned integer. That caused `GetValueForKeyAsInteger` to return the default value parameter, `LLDB_INVALID_SIGNAL_NUMBER`. This patch address the issue by extracting the signal number with the appropriate type and re-enables the test. Differential Revision: https://reviews.llvm.org/D152848 Signed-off-by: Med Ismail Bennani --- .../API/functionalities/scripted_process/TestStackCoreScriptedProcess.py | 1 - 1 file changed, 1 deletion(-) (limited to 'lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py') diff --git a/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py b/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py index bf9681ad678b..28f8630ba861 100644 --- a/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py +++ b/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py @@ -35,7 +35,6 @@ class StackCoreScriptedProcesTestCase(TestBase): @skipIfOutOfTreeDebugserver @skipIfRemote @skipIfAsan # On ASAN builds, this test times-out (rdar://98678134) - @skipIfDarwin def test_launch_scripted_process_stack_frames(self): """Test that we can launch an lldb scripted process from the command line, check its process ID and read string from memory.""" -- cgit v1.2.3