From 57abc5d6a6f393f488903c5a35e5a898fc201d3a Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 10 May 2013 21:47:16 +0000 Subject: Main changes in this patch include: - cleanup plug-in interface and use ConstStrings for plug-in names - Modfiied the BSD Archive plug-in to be able to pick out the correct .o file when .a files contain multiple .o files with the same name by using the timestamp - Modified SymbolFileDWARFDebugMap to properly verify the timestamp on .o files it loads to ensure we don't load updated .o files and cause problems when debugging The plug-in interface changes: Modified the lldb_private::PluginInterface class that all plug-ins inherit from: Changed: virtual const char * GetPluginName() = 0; To: virtual ConstString GetPluginName() = 0; Removed: virtual const char * GetShortPluginName() = 0; - Fixed up all plug-in to adhere to the new interface and to return lldb_private::ConstString values for the plug-in names. - Fixed all plug-ins to return simple names with no prefixes. Some plug-ins had prefixes and most ones didn't, so now they all don't have prefixed names, just simple names like "linux", "gdb-remote", etc. llvm-svn: 181631 --- lldb/source/Target/OperatingSystem.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lldb/source/Target/OperatingSystem.cpp') diff --git a/lldb/source/Target/OperatingSystem.cpp b/lldb/source/Target/OperatingSystem.cpp index 3fecb4a6d2c5..8ba526838777 100644 --- a/lldb/source/Target/OperatingSystem.cpp +++ b/lldb/source/Target/OperatingSystem.cpp @@ -25,7 +25,8 @@ OperatingSystem::FindPlugin (Process *process, const char *plugin_name) OperatingSystemCreateInstance create_callback = NULL; if (plugin_name) { - create_callback = PluginManager::GetOperatingSystemCreateCallbackForPluginName (plugin_name); + ConstString const_plugin_name(plugin_name); + create_callback = PluginManager::GetOperatingSystemCreateCallbackForPluginName (const_plugin_name); if (create_callback) { std::unique_ptr instance_ap(create_callback(process, true)); -- cgit v1.2.3