From 18538e213498281653fca5baefa2dec4ae51bf91 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 8 Dec 2024 17:17:51 -0800 Subject: Revert "[ELF] Optimize parseSymbolVersion" This reverts commit 2b129dacdde667137b5012d52f1d96e0ab26c749. parseSymbolVersion can be combined with computeIsPreemptible, making hasVersionSyms unneeded. --- lld/ELF/InputFiles.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'lld/ELF/InputFiles.cpp') diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index 0714c8ce6c16..2084fcfd4d65 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -1215,7 +1215,6 @@ template void ObjFile::postParse() { Err(ctx) << "TLS attribute mismatch: " << &sym << "\n>>> in " << sym.file << "\n>>> in " << this; - hasVersionSyms |= sym.hasVersionSuffix; // Handle non-COMMON defined symbol below. !sym.file allows a symbol // assignment to redefine a symbol without an error. if (!sym.isDefined() || secIdx == SHN_UNDEF) @@ -1591,8 +1590,6 @@ template void SharedFile::parse() { s->dsoDefined = true; if (s->file == this) s->versionId = idx; - symbols[firstGlobal + i] = s; - hasVersionSyms = true; } } -- cgit v1.2.3