From ea8994b5ac313d19dbd979afa7560b8b4e64f129 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Clement=20=28=E3=83=90=E3=83=AC=E3=83=B3?= =?UTF-8?q?=E3=82=BF=E3=82=A4=E3=83=B3=20=E3=82=AF=E3=83=AC=E3=83=A1?= =?UTF-8?q?=E3=83=B3=29?= Date: Fri, 22 Aug 2025 13:36:15 -0700 Subject: [flang][cuda] Remove TODO for descriptor with addendum (#155012) Addendum is allocated as part of the descriptor so there is no need for extra care. --- flang-rt/lib/cuda/allocatable.cpp | 7 ------- flang-rt/lib/cuda/pointer.cpp | 7 ------- 2 files changed, 14 deletions(-) (limited to 'flang-rt') diff --git a/flang-rt/lib/cuda/allocatable.cpp b/flang-rt/lib/cuda/allocatable.cpp index c77819e9440d..ff1a225d66ce 100644 --- a/flang-rt/lib/cuda/allocatable.cpp +++ b/flang-rt/lib/cuda/allocatable.cpp @@ -44,13 +44,6 @@ int RTDEF(CUFAllocatableAllocateSync)(Descriptor &desc, int64_t *stream, int RTDEF(CUFAllocatableAllocate)(Descriptor &desc, int64_t *stream, bool *pinned, bool hasStat, const Descriptor *errMsg, const char *sourceFile, int sourceLine) { - if (desc.HasAddendum()) { - Terminator terminator{sourceFile, sourceLine}; - // TODO: This require a bit more work to set the correct type descriptor - // address - terminator.Crash( - "not yet implemented: CUDA descriptor allocation with addendum"); - } // Perform the standard allocation. int stat{RTNAME(AllocatableAllocate)( desc, stream, hasStat, errMsg, sourceFile, sourceLine)}; diff --git a/flang-rt/lib/cuda/pointer.cpp b/flang-rt/lib/cuda/pointer.cpp index 0ed2b0a2b751..d3f5cfe8e96a 100644 --- a/flang-rt/lib/cuda/pointer.cpp +++ b/flang-rt/lib/cuda/pointer.cpp @@ -25,13 +25,6 @@ RT_EXT_API_GROUP_BEGIN int RTDEF(CUFPointerAllocate)(Descriptor &desc, int64_t *stream, bool *pinned, bool hasStat, const Descriptor *errMsg, const char *sourceFile, int sourceLine) { - if (desc.HasAddendum()) { - Terminator terminator{sourceFile, sourceLine}; - // TODO: This require a bit more work to set the correct type descriptor - // address - terminator.Crash( - "not yet implemented: CUDA descriptor allocation with addendum"); - } // Perform the standard allocation. int stat{ RTNAME(PointerAllocate)(desc, hasStat, errMsg, sourceFile, sourceLine)}; -- cgit v1.2.3