From 89c8e000cf9905ae4b895d02963ef557d1e5eec9 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Thu, 23 Apr 2009 18:22:55 +0000 Subject: Fix handling of C99 "extern inline" semantics when dealing with multiple declarations of the function. Should fix PR3989 and . llvm-svn: 69905 --- clang/lib/CodeGen/CodeGenModule.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'clang/lib/CodeGen/CodeGenModule.cpp') diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index c07eac993bee..378223e3a71b 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -242,7 +242,7 @@ GetLinkageForFunction(const FunctionDecl *FD, const LangOptions &Features) { // this is C89 mode, we use to GNU semantics. if (FD->hasAttr() || (!Features.C99 && !Features.CPlusPlus)) { // extern inline in GNU mode is like C99 inline. - if (FD->getStorageClass() == FunctionDecl::Extern) + if (FD->isC99InlineDefinition()) return CodeGenModule::GVA_C99Inline; // Normal inline is a strong symbol. return CodeGenModule::GVA_StrongExternal; @@ -254,11 +254,10 @@ GetLinkageForFunction(const FunctionDecl *FD, const LangOptions &Features) { return CodeGenModule::GVA_CXXInline; assert(Features.C99 && "Must be in C99 mode if not in C89 or C++ mode"); - // extern inline in C99 is a strong definition. - if (FD->getStorageClass() == FunctionDecl::Extern) - return CodeGenModule::GVA_StrongExternal; - - return CodeGenModule::GVA_C99Inline; + if (FD->isC99InlineDefinition()) + return CodeGenModule::GVA_C99Inline; + + return CodeGenModule::GVA_StrongExternal; } /// SetFunctionDefinitionAttributes - Set attributes for a global. -- cgit v1.2.3