From 55a719835ddc8800f94331e7ffde19cb011d325d Mon Sep 17 00:00:00 2001 From: Steve Naroff Date: Fri, 3 Apr 2009 09:44:50 +0000 Subject: Add a comment/FIXME so Eli can sleep better:-)) llvm-svn: 68379 --- clang/lib/CodeGen/CodeGenModule.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'clang/lib/CodeGen/CodeGenModule.cpp') diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 1bf73db177c4..b92776face02 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -1039,6 +1039,11 @@ GetAddrOfConstantCFString(const StringLiteral *Literal) { strictConversion); assert(Result == conversionOK && "UTF-8 to UTF-16 conversion failed"); + // FIXME: Storing UTF-16 in a C string is a hack to test Unicode strings + // without doing more surgery to this routine. Since we aren't explicitly + // checking for endianness here, it's also a bug (when generating code for + // a target that doesn't match the host endianness). Modeling this as an i16 + // array is likely the cleanest solution. StringLength = ToPtr-&ToBuf[0]; str.assign((char *)&ToBuf[0], StringLength*2); // Twice as many UTF8 chars. isUTF16 = true; -- cgit v1.2.3