From 29eff88fc800c7aad00dc39c261cbba3df360ba2 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Tue, 14 Apr 2009 06:19:49 +0000 Subject: Add a comment on SetGlobalValueAttributes. llvm-svn: 69029 --- clang/lib/CodeGen/CodeGenModule.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'clang/lib/CodeGen/CodeGenModule.cpp') diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index be6ba2338a16..1dafd39b2c1a 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -221,6 +221,11 @@ void CodeGenModule::EmitAnnotations() { gv->setSection("llvm.metadata"); } +/// SetGlobalValueAttributes - Set attributes for a global. +/// +/// FIXME: This is currently only done for aliases and functions, but +/// not for variables (these details are set in +/// EmitGlobalVarDefinition for variables). void CodeGenModule::SetGlobalValueAttributes(const Decl *D, GVALinkage Linkage, llvm::GlobalValue *GV, @@ -265,8 +270,8 @@ void CodeGenModule::SetGlobalValueAttributes(const Decl *D, setGlobalVisibility(GV, D); // Only add to llvm.used when we see a definition, otherwise we - // might add multiple times or risk the value being replaced by a - // subsequent RAUW. + // might add it multiple times or risk the value being replaced by + // a subsequent RAUW. if (D->hasAttr()) AddUsedGlobal(GV); } -- cgit v1.2.3