diff options
| author | Teresa Johnson <tejohnson@google.com> | 2023-04-19 14:51:10 -0700 |
|---|---|---|
| committer | Teresa Johnson <tejohnson@google.com> | 2023-04-20 11:45:15 -0700 |
| commit | 3adc6e03080c6d38a51f5c5b6744b7c0d9c7541b (patch) | |
| tree | e95855cb0ec33430203bd1d118fa48d6990f2af0 /llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll | |
| parent | 3ba4d082da3dd6856887774fab694f81adc15a64 (diff) | |
[ThinLTO] Remove BlockCount for non partial sample profile builds
As pointed out in
https://discourse.llvm.org/t/undeterministic-thin-index-file/69985, the
block count added to distributed ThinLTO index files breaks incremental
builds on ThinLTO - if any linked file has a different number of BBs,
then the accumulated sum placed in the index files will change, causing
all ThinLTO backend compiles to be redone.
The block count is only used for scaling of partial sample profiles, and
was added in D80403 for D79831.
This patch simply removes this field from the index files of non partial
sample profile compiles, which is NFC on the output of the compiler.
We subsequently need to see if this can be removed for partial sample
profiles without signficant performance loss, or redesigned in a way
that does not destroy caching.
Differential Revision: https://reviews.llvm.org/D148746
Diffstat (limited to 'llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll')
| -rw-r--r-- | llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll b/llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll index a59bae3cd757..e8e2b0de91b6 100644 --- a/llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll +++ b/llvm/test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll @@ -33,7 +33,6 @@ ; CHECK-NEXT: <VALUE_GUID op0=26 op1=123/> ; op4=none1 op6=hot1 op8=cold1 op10=none2 op12=hot2 op14=cold2 op16=none3 op18=hot3 op20=cold3 op22=123 ; CHECK-NEXT: <PERMODULE_PROFILE {{.*}} op7=7 op8=0 op9=1 op10=3 op11=4 op12=1 op13=8 op14=0 op15=2 op16=3 op17=5 op18=1 op19=9 op20=0 op21=3 op22=3 op23=6 op24=1 op25=26 op26=4/> -; CHECK-NEXT: <BLOCK_COUNT op0=4/> ; CHECK-NEXT: </GLOBALVAL_SUMMARY_BLOCK> ; CHECK: <STRTAB_BLOCK @@ -62,7 +61,6 @@ ; COMBINED-NEXT: <COMBINED abbrevid= ; COMBINED-NEXT: <COMBINED_PROFILE {{.*}} op9=[[NONE1:.*]] op10=0 op11=[[HOT1:.*]] op12=3 op13=[[COLD1:.*]] op14=1 op15=[[NONE2:.*]] op16=0 op17=[[HOT2:.*]] op18=3 op19=[[COLD2:.*]] op20=1 op21=[[NONE3:.*]] op22=0 op23=[[HOT3:.*]] op24=3 op25=[[COLD3:.*]] op26=1/> ; COMBINED-NEXT: <COMBINED abbrevid= -; COMBINED-NEXT: <BLOCK_COUNT op0=13/> ; COMBINED-NEXT: </GLOBALVAL_SUMMARY_BLOCK> |