diff options
| author | Jason Molenda <jason@molenda.com> | 2023-03-08 17:59:46 -0800 |
|---|---|---|
| committer | Jason Molenda <jason@molenda.com> | 2023-03-08 18:02:20 -0800 |
| commit | 8db8a4e8eddf91bfaee62f83ff10a51e7125d4e4 (patch) | |
| tree | 5c64bb9d4f0d68f90983cfb6edacb92628df8209 /lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp | |
| parent | 0f2f378425821de77e50a0dcb67c4504389a56e8 (diff) | |
Clean up conditional, don't set load binaries twice
Follow Alex Langford's feedback to my patch from
https://reviews.llvm.org/D145547 , and fix a
side issue I noticed while testing this, where
binaries loaded via LC_NOTE metadata were loaded
in the Target twice unnecessarily.
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp')
| -rw-r--r-- | lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp index d41279ce864c..c5f04557ae61 100644 --- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp +++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp @@ -7032,6 +7032,8 @@ bool ObjectFileMachO::LoadCoreFileImages(lldb_private::Process &process) { &process, image.filename, image.uuid, image.load_address, false /* value_is_offset */, image.currently_executing, false /* notify */); + if (module_sp) + continue; } // If we have a slide, we need to find the original binary @@ -7042,6 +7044,8 @@ bool ObjectFileMachO::LoadCoreFileImages(lldb_private::Process &process) { &process, image.filename, image.uuid, image.slide, true /* value_is_offset */, image.currently_executing, false /* notify */); + if (module_sp) + continue; } // Try to find the binary by UUID or filename on the local |